GetPagedPlayouts: TotalCount ignores the query filter, so a filtered page reports the unfiltered total
#758
Closed
opened 2026-08-06 21:49:47 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#758
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
GetPagedPlayoutsHandlercomputes the count before applying the filter:So
PagedPlayoutsViewModel.Countis the total number of playout rows, not the number matchingquery— and it does not even account for theChannel != nullfilter applied to the page query.Why it surfaced now: until ersatztv#754/#757 no MCP caller could pass
queryat all(
ToolArgumentValidatorrejects undeclared arguments), so the discrepancy was unreachable from thatsurface.
ersatztv_list_playoutsnow declares it, so an agent filtering by channel name sees atotalCountthat does not match its own page and will page to a completeness target it can neverreach. Pre-existing server bug; #757 is what exposed it, not what caused it.
This is the same family as #690 (rerun collections: paged list
TotalCountignores the search query).Worth checking whether the two share a fix.
Done-when
GetPagedPlayoutsHandlercounts the SAME query it pages, filter and allClaiming this (Claude Code session, 2026-08-26), bundled with the sibling issue — #758 and #690 are the same defect shape: a paged query handler computes
CountAsyncon the unfilteredDbSetwhile the page query applies aQuery/Wherepredicate, soTotalCountreports the whole table.Pre-claim checks per
process.parallel-session-claim: no open PR referencing either issue (only Renovate PRs are open), no remote branch naming 690/758/paged/totalcount, no prior comments on either issue, freshgit fetch origin main(at7453dd3a8).Scope taken: not just the two named handlers. Per #690 Done-when box 3 ("check the sibling paged handlers for the same shape") and the "an issue's file list is not the population" lesson, this sweeps every paged handler in
ErsatzTV.Applicationfor the shape and records each site, including any deliberate non-fix.Closing record
Outcome: Fixed in PR #833, bundled with #690 — box 3 ("checked against #690 for a shared idiom /
shared fix") resolved as yes, and it is the same fix.
GetPagedPlayoutsHandlernow derives both itscount and its page from one
IQueryable. The issue's premise was right on both counts: pre-existingserver bug, and #757 exposed rather than caused it.
Root cause: The count was
dbContext.Playouts.CountAsync(ct)— the whole table — while the pageapplied both a
Channel != nullfilter and the optionalQuery. One mechanism shared with #690 andfour other handlers; the fix is structural so the two cannot drift again.
Correction to the issue's framing, on evidence: the
Channel != nullhalf is DEFENSIVE, not alive defect.
Playout.ChannelIdis non-nullable withDeleteBehavior.Cascadeand both productionconnection strings set
foreign keys=true, so an orphaned playout is unreachable while the FK holds —the pre-fix and post-fix counts are equal on every real database. The
Queryhalf is the live bug,and it is reachable exactly as described:
ersatztv_list_playoutsdeclaringquery(#757) is whatmade it visible from the MCP surface.
Decisions/conventions changed: added
api.paged-count-matches-page-query(see #690's record forthe full statement).
Reusable knowledge:
its count was a structural one applied unconditionally, so no search query was needed to expose the
discrepancy in principle. Enumerate every clause on the page query, not just the
if (query)one.(rerun-collections, multi-collections, playouts) reach a controller; the other three have no
production caller and were latent. The SPA reads this total in two places
(
DashboardScreen,PlayoutsScreen) via a single un-looped request, so no completeness loop wasaffected — worth checking before describing a count bug as user-visible paging breakage.
Verification: see #690's closing record — same PR, same suites, same mutation proofs. Playout-
specific: the test seeds a playout whose channel row is absent to make the
Channel != nullclauseobservable at all, which is only possible because the test harness disables FKs; that is labelled in
the test as the corruption-only case it is, not presented as a reachable state.
Deferred: #832 (MediaCards: 1-based paging, delete-or-keep, and the include-chain gap).
Docs updated:
docs/decisions/records/api/paged-count-matches-page-query.md(new),docs/decisions/README.md(regenerated),docs/api-conventions.md,docs/README.md.