timothy/ersatztv
1
0
Fork 0
Code Issues 57 Pull Requests 6 Actions Packages Projects Releases 9 Wiki Activity

fix(spa): remove hard-coded Playouts nav badge (#218) #226

Closed
timothy wants to merge 0 commits from fix/218-playouts-badge into main
pull from: fix/218-playouts-badge
merge into: :main
Conversation 1 Commits - Files Changed -
timothy commented 2026-07-10 23:56:34 +02:00
Owner
Copy Link
Copy Source

Closes #218.

  • Removes the hard-coded badge: 3 from the Playouts nav route (design-mock scaffolding, never wired to data; Blazor had no equivalent). Badge mechanism kept for future live use. No other hard-coded nav badges exist.
  • The "1 failing" footer chip is NOT a bug: live GET /api/health data — on dev machines the failing check is genuinely FFmpeg Capabilities (Homebrew ffmpeg lacks subtitles/zscale filters; prod image has them). Verified against a fresh scratch instance during the #220 E2E run.

tsc + 477/477 web tests green.

🤖 Generated with Claude Code

Closes #218. - Removes the hard-coded `badge: 3` from the Playouts nav route (design-mock scaffolding, never wired to data; Blazor had no equivalent). Badge mechanism kept for future live use. No other hard-coded nav badges exist. - The "1 failing" footer chip is NOT a bug: live `GET /api/health` data — on dev machines the failing check is genuinely `FFmpeg Capabilities` (Homebrew ffmpeg lacks subtitles/zscale filters; prod image has them). Verified against a fresh scratch instance during the #220 E2E run. tsc + 477/477 web tests green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
timothy added 1 commit 2026-07-10 23:56:34 +02:00
fix(spa): remove hard-coded Playouts nav badge (fixes #218)
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m49s
Details
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 12s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 10m43s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details
6823b42dbc 
The sidebar "Playouts 3" badge on a fresh empty DB was design-mock
scaffolding (badge: 3 hard-coded in the routes array) never wired to
live data; Blazor had no equivalent. Removed the value but kept the
nav-badge mechanism (ScreenRoute.badge, NavItem badge/badgeTone props)
in place since it's a plausible future home for a live warnings count.

The footer "1 failing" chip reported in the same issue is NOT a bug:
summarizeHealth renders live GET /api/health data, and on a fresh
local dev instance the genuinely failing check is FFmpeg Capabilities
(local Homebrew ffmpeg lacks the subtitles/zscale filters that prod's
ffmpeg image has). No code change for that half.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
timothy added 1 commit 2026-07-11 00:31:41 +02:00
Merge main: CI MySQL host-port unpin (collision fix)
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 19s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 6m8s
Details
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 15m30s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details
b70713fde8
timothy commented 2026-07-11 11:37:51 +02:00
Author
Owner
Copy Link
Copy Source

Merged to main via integration PR #239 (all six gate-batch branches integrated in one CI round after pairwise doc conflicts; this PR's commits are reachable from main — see the merge commits there). Closing manually since Gitea did not auto-detect the branch merge.

Merged to main via integration PR #239 (all six gate-batch branches integrated in one CI round after pairwise doc conflicts; this PR's commits are reachable from main — see the merge commits there). Closing manually since Gitea did not auto-detect the branch merge.
timothy closed this pull request 2026-07-11 11:37:51 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ad-hoc
One-off / ad-hoc work not tracked by a dedicated issue
 api
REST API / HTTP endpoints
 bug
Something isn't working
 ci-cd
Build, test, deploy pipeline
 content
Channel content / schedules / playlists
 dependencies
Dependency updates (Renovate)
 enhancement
New feature or improvement
 frontend
ChicoryTV React SPA frontend
 in-progress
Claimed by an active session — do not pick up
 jellyfin
Jellyfin tuner / IPTV integration
 parked
Excluded from automatic queue pickup; work only when explicitly selected
 priority: high
priority: low
priority: medium
review
Adversarial review finding
 security
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate timothy (Timothy)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#226