#197 Bundle C: OpenAPI contract honesty (#287) + wrap raw VMs / nullable DTOs (#288) + channel re-key #296

Merged

timothy merged 8 commits from bundle-c-197-contract into main 2026-07-12 12:25:21 +02:00

Conversation 0 Commits 8 Files Changed 74

+7050 -1076

8 Commits

Author	SHA1	Message	Date
timothyandClaude Opus 4.8	c40e78d840	fix(api): #197 Bundle C review nits — order-independent operationIds + nullable MediaSources fields ... Refs #287 #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 12:08:50 +02:00
timothyandClaude Opus 4.8	a918ccd60c	docs: #197 Bundle C — api-conventions/decisions/rest-api sync ... §2 raw-VM wrapping + universal #nullable enable; §3a/§5/§7a/§9 updated for reset re-key, DayOfWeek string, header-only Version, security-by-construction; 3 decisions.md entries (#287/#288/channel-key); rest-api.md reset route. Refs #287 #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:38:43 +02:00
timothyandClaude Opus 4.8	70f357f8f9	feat(api): #288 ChannelDetailResponseModel for edit form + SPA repoints + final regen ... Mint ChannelDetailResponseModel (faithful detail DTO exposing the raw editable field set the channel editor reads: raw FFmpegProfileId/WatermarkId/FallbackFillerId ids, the mode enums, logo, playoutCount, id) and route GetById/Create/Update through it, replacing the lean list ChannelResponseModel that resolved the profile to a name and dropped the editable ids (a functional regression for draftFromChannel). The lean ChannelResponseModel stays unchanged for GET /api/channels. webEncodedName dropped (SPA never reads it). Logo is mirrored as a Core ChannelLogoResponseModel since the Application ArtworkContentTypeModel can't be referenced from Core. Repoint the hand-written SPA client aliases now that the VMs are gone from the schema: Channel -> ChannelDetailResponseModel, MediaCollection/SmartCollection -> *ResponseModel, ProgramSchedule -> ProgramScheduleResponseModel. Fix #288 honest-nullability test fallout in search.test.ts (null -> [] for now-non-null id arrays). Include the already-on-disk playouts.ts WithDayNames removal and regenerate v1.json + v1.d.ts + endpoint-index.md (authoritative final regen; the reset endpoint's {channelNumber}->{id} re-key surfaces in the generated docs and the OpenApi error-contract test). Refs #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:33:39 +02:00
timothy	74170611da	Merge branch 'bundle-c/channel' into bundle-c-197-contract	2026-07-12 02:08:13 +02:00
timothy	9e5087b3cd	Merge branch 'bundle-c/288' into bundle-c-197-contract	2026-07-12 02:08:12 +02:00
timothyandClaude Opus 4.8	5f89bfc1a0	feat(api): #288/#197 wrap ChannelViewModel + re-key playout/reset to {id} ... GetById/Create/Update return ChannelResponseModel via new GetChannelByIdForApi read-side query; POST /api/channels/{id:int}/playout/reset (new GetPlayoutIdByChannelId; by-number kept for HlsSessionWorker broadcast). Refs #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:08:12 +02:00
timothyandClaude Opus 4.8	171364d0e8	feat(api): #287 OpenAPI contract honesty by construction ... ApiKey security scheme + per-op security/401 via shared EndpointRequiresKey predicate (no drift from enforcement); synthesized stable operationIds; 400 ValidationProblemDetails on binding ops; DayOfWeek as string enum. Refs #287 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:08:12 +02:00
timothyandClaude Opus 4.8	fecf16d3d2	feat(api): #288 wrap raw VMs, nullable-honest DTOs, search pageNum ... 24 #nullable enable flips across ErsatzTV.Core/Api; Collection/Schedule/ SmartCollection/Resolution VMs wrapped in ResponseModels (Version now header-only, SPA-verified); pageNum threaded into GET /api/search. Refs #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:08:12 +02:00