timothy/ersatztv
1
0
Fork 0
Code Issues 57 Pull Requests 6 Actions Packages Projects Releases 9 Wiki Activity

fix(#238): wire TopBar primary-action on create screens, drop dead buttons #324

Merged
timothy merged 2 commits from fix/238-topbar-primary-action into main 2026-07-12 23:51:26 +02:00
Conversation 1 Commits 2 Files Changed 13
+207 -41
2 Commits
Author SHA1 Message Date
timothyandClaude Opus 4.8 51b67dea06 fix(#238): review — trakt sub-route no-op + data-driven wiring test
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 9s
Details
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 11s
Details
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 8s
Details
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 7s
Details
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m59s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 8m35s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details
Build ErsatzTV Image / Docs update reminder (push) Has been skipped
Details
Build ErsatzTV Image / decisions.md append-only (push) Has been skipped
Details
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (push) Has been skipped
Details
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (push) Has been skipped
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (push) Successful in 4m18s
Details
Build ErsatzTV Image / Build & test (.NET) (push) Successful in 5m25s
Details
Build ErsatzTV Image / Build & push image (amd64) (push) Successful in 4m26s
Details 
Cold-review follow-ups (both non-blocking):
- Low: the TopBar "Add Trakt List" button was a silent no-op on the
  /app/trakt-lists/{id} detail sub-route (setAddOpen state isn't rendered by
  the editor branch, and the screen is keyed by pathname so the state
  wouldn't survive a navigate). Guard on editingId: route back to the list
  from the detail view, open the dialog from the list.
- Nit: the invariant test only spot-checked 2 screens. Replaced with a
  data-driven it.each over the 4 URL-navigating create screens (channels,
  filler, ffmpeg, watermarks) asserting each banner actually navigates — a
  typo'd route id now fails red. Docs wording corrected to match.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-07-12 23:35:59 +02:00
timothyandClaude Opus 4.8 612b11589c fix(#238): wire TopBar primary-action on create screens, drop dead buttons 
The shell TopBar rendered a primary-action button (Plus icon) for every
screen, but only SchedulesScreen subscribed to its ctv:primary-action event
— so every other screen's button was dead (a labelled no-op, or a bare "+"
for the ~10 routes whose primaryAction was '').

Resolution (issue #238): the Plus-icon button is a "create new item"
affordance. Keep + wire it only on the 8 list screens with a single create
flow (channels, schedules, multi/rerun collections, trakt lists, filler
presets, ffmpeg profiles, watermarks) via a shared usePrimaryAction hook
(web/src/primaryAction.ts); drop it (primaryAction: '') everywhere else —
where the action isn't a create (Save/Refresh/Play/Validate/Reset/Scan, all
of which have correct in-body controls), is ambiguous (collections tabs), a
silent no-op (builder, playlists), or misplaced (dashboard, libraries). The
TopBar now renders the button only when primaryAction is non-empty.

Also relabels the apiKey route's stale post-#295 "Save key"/description.
Docs: spa-conventions.md §10 + decisions.md 2026-07-12.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-07-12 23:35:59 +02:00