fix(api): protect local library path details #371

Merged
timothy merged 2 commits from codex/334-sensitive-local-paths into main 2026-07-16 19:16:52 +02:00
Owner

Summary

  • require authenticated access for local-library detail responses that expose server filesystem paths
  • keep the ordinary local-library catalog list in the read-auth opt-out tier
  • add a reflective regression test and document the sensitive-read boundary

Verification

  • TZ=UTC dotnet restore ErsatzTV.sln -v minimal
  • TZ=UTC dotnet build ErsatzTV.sln --no-restore -v minimal
  • TZ=UTC dotnet test ErsatzTV.sln --no-build -v minimal
  • focused API authorization/security tests (23 passed)
  • scripts/update-openapi.sh and npm run generate:api (generated artifacts unchanged)
  • pre-push API check, lint, typecheck, and production web build

E2E

Exempt: this is an authorization-metadata boundary on an existing read endpoint with no UI or write-path behavior. The regression is covered reflectively and by the existing authorization filter tests.

Fixes #334

## Summary - require authenticated access for local-library detail responses that expose server filesystem paths - keep the ordinary local-library catalog list in the read-auth opt-out tier - add a reflective regression test and document the sensitive-read boundary ## Verification - `TZ=UTC dotnet restore ErsatzTV.sln -v minimal` - `TZ=UTC dotnet build ErsatzTV.sln --no-restore -v minimal` - `TZ=UTC dotnet test ErsatzTV.sln --no-build -v minimal` - focused API authorization/security tests (23 passed) - `scripts/update-openapi.sh` and `npm run generate:api` (generated artifacts unchanged) - pre-push API check, lint, typecheck, and production web build ## E2E Exempt: this is an authorization-metadata boundary on an existing read endpoint with no UI or write-path behavior. The regression is covered reflectively and by the existing authorization filter tests. Fixes #334
timothy added 1 commit 2026-07-16 18:49:55 +02:00
fix(api): protect local library path details
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 7s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 8s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 5m30s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 3m28s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 55s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 4m41s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 9m58s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
489956b167
Fixes #334

Co-Authored-By: OpenAI Codex <codex@openai.com>
timothy added 1 commit 2026-07-16 18:55:33 +02:00
test(api): assert effective local library auth
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 8s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 9s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 5m15s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 2m53s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 56s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 7m13s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 10m36s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
fe4706474e
Refs #334

Co-Authored-By: OpenAI Codex <codex@openai.com>
Author
Owner

Review-verdict: MERGEABLE @ fe4706474e

Cold independent security review found no correctness or security issues. A residual test-hardening note was addressed in follow-up commit fe470647: effective controller-plus-action authentication metadata is now asserted, and the reviewer re-reviewed that delta cleanly.

Review-verdict: MERGEABLE @ fe4706474ec3ed901411ee7ec3b8a467fd4ae67e Cold independent security review found no correctness or security issues. A residual test-hardening note was addressed in follow-up commit `fe470647`: effective controller-plus-action authentication metadata is now asserted, and the reviewer re-reviewed that delta cleanly.
timothy merged commit 72d47ef052 into main 2026-07-16 19:16:52 +02:00
timothy deleted branch codex/334-sensitive-local-paths 2026-07-16 19:16:52 +02:00
Sign in to join this conversation.