Two missing-base-reset CSS defects in the ChicoryTV SPA shell — same file family, both confirmed by rendering the real running app (headless Playwright), not source-reading.
#373 — white border on the login / boot pages (and, per the reporter, all pages)
The browser-default body { margin: 8px } was never reset. It framed every full-viewport layout — the app shell and the shell-less .ctv-auth-page boot pages (login/setup/checking/error), both min-height:100vh — with a light border on all four edges. Root cause confirmed: getComputedStyle(document.body).margin === "8px", body/html background transparent.
Fix:html, body { margin: 0 } + paint body { background: var(--surface-app) } so any residual gap/overscroll stays dark. Matches the design-system reset (design-system/components/forms/forms.card.html, .../chicorytv-admin/*.html).
The SPA ships no global box-sizing reset (default content-box), so .ctv-nav-item { width:100%; padding:0 10px } overflowed .ctv-nav (overflow:auto) by 20px → a horizontal scrollbar in the sidebar. Root cause confirmed: navScrollWidth 236 > navClientWidth 216, item box-sizing: content-box, offsetWidth 220.
Fix: scope box-sizing: border-box to .ctv-nav-item (root-cause, zero blast radius — the item now fits the nav content width exactly). Deliberately not a global * { box-sizing } reset: the whole SPA is authored under content-box, so a global switch is a broad regression risk unjustified for a low-priority cosmetic fix. Documented in spa-conventions.md so the next author sets border-box locally instead.
Nav vertical scroll (intended) and label ellipsis unaffected. npm run lint clean, 780 vitest tests pass, npm run build green.
Docs
docs/spa-conventions.md §1 (Styling) now records the base reset and the deliberate absence of a global box-sizing reset.
Review note
Pure-SPA/CSS leaf, no server-state effect → live-E2E not required (rendered anyway to satisfy the issues' "render, don't source-read" Done-when). A cold-context adversarial review over this diff follows to satisfy the "adversarial review passed" box.
Fixes #373. Fixes #377.
Two missing-base-reset CSS defects in the ChicoryTV SPA shell — same file family, both **confirmed by rendering the real running app** (headless Playwright), not source-reading.
## #373 — white border on the login / boot pages (and, per the reporter, all pages)
The browser-default `body { margin: 8px }` was never reset. It framed every full-viewport layout — the app shell **and** the shell-less `.ctv-auth-page` boot pages (login/setup/checking/error), both `min-height:100vh` — with a light border on all four edges. Root cause confirmed: `getComputedStyle(document.body).margin === "8px"`, `body`/`html` background transparent.
**Fix:** `html, body { margin: 0 }` + paint `body { background: var(--surface-app) }` so any residual gap/overscroll stays dark. Matches the design-system reset (`design-system/components/forms/forms.card.html`, `.../chicorytv-admin/*.html`).
## #377 — sidebar scrolls horizontally
The SPA ships **no** global `box-sizing` reset (default `content-box`), so `.ctv-nav-item { width:100%; padding:0 10px }` overflowed `.ctv-nav` (`overflow:auto`) by 20px → a horizontal scrollbar in the sidebar. Root cause confirmed: `navScrollWidth 236 > navClientWidth 216`, item `box-sizing: content-box`, `offsetWidth 220`.
**Fix:** scope `box-sizing: border-box` to `.ctv-nav-item` (root-cause, zero blast radius — the item now fits the nav content width exactly). Deliberately **not** a global `* { box-sizing }` reset: the whole SPA is authored under content-box, so a global switch is a broad regression risk unjustified for a low-priority cosmetic fix. Documented in spa-conventions.md so the next author sets border-box locally instead.
## Verification (real render, warm theme, 1280px + 900px)
| | before | after |
|---|---|---|
| `body` margin | `8px` | `0px` |
| boot-page / shell edge border | light frame all sides | none (dark to edge) |
| sidebar nav h-scroll | `scrollW 236 > clientW 216` (scrollbar) | `216 == 216`, none |
| nav-item box-sizing | content-box (offsetW 220) | border-box (offsetW 200) |
| page h-scroll @900px | — | none |
Nav vertical scroll (intended) and label ellipsis unaffected. `npm run lint` clean, **780 vitest tests pass**, `npm run build` green.
## Docs
`docs/spa-conventions.md` §1 (Styling) now records the base reset and the deliberate absence of a global box-sizing reset.
## Review note
Pure-SPA/CSS leaf, no server-state effect → live-E2E not required (rendered anyway to satisfy the issues' "render, don't source-read" Done-when). A cold-context adversarial review over this diff follows to satisfy the "adversarial review passed" box.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Two missing-base-reset defects in the ChicoryTV SPA shell, both confirmed by
rendering the real app (not source-reading):
- #373: the browser-default `body { margin: 8px }` was never reset, so it framed
every full-viewport layout — the app shell and the shell-less `.ctv-auth-page`
boot pages (login/setup/checking/error), both `min-height:100vh` — with a light
border on all four edges. Fix: `html, body { margin: 0 }` + paint the app surface
on `body` so any residual gap/overscroll stays dark (matches the design-system
reset in forms.card.html / chicorytv-admin templates). Verified body margin 0 and
no edge border on the boot page and the shell, warm theme, 1280px and 900px.
- #377: the SPA ships no global `box-sizing` reset (default content-box), so
`.ctv-nav-item { width:100%; padding:0 10px }` overflowed `.ctv-nav`
(`overflow:auto`) by 20px → a horizontal scrollbar in the sidebar. Fix: scope
`box-sizing: border-box` to `.ctv-nav-item`. Verified nav scrollWidth==clientWidth
(216==216) and no horizontal scroll after the fix; the intended vertical nav scroll
is unaffected.
Docs: spa-conventions.md §1 records the base reset and the deliberate absence of a
global box-sizing reset (set border-box locally when combining width:100% + padding).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cold-context adversarial review (review-only agent, fresh context) over the full diff — all five risk angles traced to source, no defects:
Portaled overlays — the only body portal is overlay.tsx; its .ctv-dialog-overlay backdrop is position:fixed; inset:0; z-index:100; rgba(0,0,0,.55) painted over everything → body background sits strictly behind it, cannot alter it.
--surface-app defined before paint — declared unconditionally at :root (design-system/tokens/colors.css:44), imported before shell.css; no theme/JS gate. Undefined-case fallback is transparent = the exact pre-fix state (non-regression).
Box-sizing scope sufficient — .ctv-nav-item is the only width:100%+padding element inside .ctv-nav (the sole overflow:auto scroller); .ctv-nav-section is width:auto (fits), health/brand rows are outside .ctv-nav. border:0 means height is unchanged.
html,body{margin:0} — standard reset, nothing depended on the 8px.
Theme coverage — --surface-app is dark in warm (#12100E) and cool/dual (#0F1115); both artifacts are theme-independent geometry, so warm-only render is adequate.
Cold-context adversarial review (review-only agent, fresh context) over the full diff — all five risk angles traced to source, no defects:
1. **Portaled overlays** — the only body portal is `overlay.tsx`; its `.ctv-dialog-overlay` backdrop is `position:fixed; inset:0; z-index:100; rgba(0,0,0,.55)` painted *over* everything → body background sits strictly behind it, cannot alter it.
2. **`--surface-app` defined before paint** — declared unconditionally at `:root` (`design-system/tokens/colors.css:44`), imported before `shell.css`; no theme/JS gate. Undefined-case fallback is `transparent` = the exact pre-fix state (non-regression).
3. **Box-sizing scope sufficient** — `.ctv-nav-item` is the only `width:100%`+padding element inside `.ctv-nav` (the sole `overflow:auto` scroller); `.ctv-nav-section` is `width:auto` (fits), health/brand rows are outside `.ctv-nav`. `border:0` means height is unchanged.
4. **`html,body{margin:0}`** — standard reset, nothing depended on the 8px.
5. **Theme coverage** — `--surface-app` is dark in warm (`#12100E`) and cool/dual (`#0F1115`); both artifacts are theme-independent geometry, so warm-only render is adequate.
Review-verdict: MERGEABLE @ 1575b9b53788d624eebb8acea15481420c5a69ee
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #373. Fixes #377.
Two missing-base-reset CSS defects in the ChicoryTV SPA shell — same file family, both confirmed by rendering the real running app (headless Playwright), not source-reading.
#373 — white border on the login / boot pages (and, per the reporter, all pages)
The browser-default
body { margin: 8px }was never reset. It framed every full-viewport layout — the app shell and the shell-less.ctv-auth-pageboot pages (login/setup/checking/error), bothmin-height:100vh— with a light border on all four edges. Root cause confirmed:getComputedStyle(document.body).margin === "8px",body/htmlbackground transparent.Fix:
html, body { margin: 0 }+ paintbody { background: var(--surface-app) }so any residual gap/overscroll stays dark. Matches the design-system reset (design-system/components/forms/forms.card.html,.../chicorytv-admin/*.html).#377 — sidebar scrolls horizontally
The SPA ships no global
box-sizingreset (defaultcontent-box), so.ctv-nav-item { width:100%; padding:0 10px }overflowed.ctv-nav(overflow:auto) by 20px → a horizontal scrollbar in the sidebar. Root cause confirmed:navScrollWidth 236 > navClientWidth 216, itembox-sizing: content-box,offsetWidth 220.Fix: scope
box-sizing: border-boxto.ctv-nav-item(root-cause, zero blast radius — the item now fits the nav content width exactly). Deliberately not a global* { box-sizing }reset: the whole SPA is authored under content-box, so a global switch is a broad regression risk unjustified for a low-priority cosmetic fix. Documented in spa-conventions.md so the next author sets border-box locally instead.Verification (real render, warm theme, 1280px + 900px)
bodymargin8px0pxscrollW 236 > clientW 216(scrollbar)216 == 216, noneNav vertical scroll (intended) and label ellipsis unaffected.
npm run lintclean, 780 vitest tests pass,npm run buildgreen.Docs
docs/spa-conventions.md§1 (Styling) now records the base reset and the deliberate absence of a global box-sizing reset.Review note
Pure-SPA/CSS leaf, no server-state effect → live-E2E not required (rendered anyway to satisfy the issues' "render, don't source-read" Done-when). A cold-context adversarial review over this diff follows to satisfy the "adversarial review passed" box.
🤖 Generated with Claude Code
Cold-context adversarial review (review-only agent, fresh context) over the full diff — all five risk angles traced to source, no defects:
overlay.tsx; its.ctv-dialog-overlaybackdrop isposition:fixed; inset:0; z-index:100; rgba(0,0,0,.55)painted over everything → body background sits strictly behind it, cannot alter it.--surface-appdefined before paint — declared unconditionally at:root(design-system/tokens/colors.css:44), imported beforeshell.css; no theme/JS gate. Undefined-case fallback istransparent= the exact pre-fix state (non-regression)..ctv-nav-itemis the onlywidth:100%+padding element inside.ctv-nav(the soleoverflow:autoscroller);.ctv-nav-sectioniswidth:auto(fits), health/brand rows are outside.ctv-nav.border:0means height is unchanged.html,body{margin:0}— standard reset, nothing depended on the 8px.--surface-appis dark in warm (#12100E) and cool/dual (#0F1115); both artifacts are theme-independent geometry, so warm-only render is adequate.Review-verdict: MERGEABLE @
1575b9b537