timothy/ersatztv
1
0
Fork 0
Code Issues 57 Pull Requests 6 Actions Packages Projects Releases 9 Wiki Activity

fix(409,447): LibrariesScreen 'Never scanned' label + stabilize flaky scan-poll test #451

Merged
timothy merged 1 commits from fix/409-447-librariesscreen-neverscanned into main 2026-07-18 18:18:46 +02:00
Conversation 1 Commits 1 Files Changed 2
+58 -4
timothy commented 2026-07-18 16:57:30 +02:00
Owner
Copy Link
Copy Source

#409: never-scanned local libraries rendered a bogus '12:00 AM' because the API serializes DateTime.MinValue as a truthy ISO string that formatDateTime happily parses. Added a client-side hasScanned() sentinel guard (treats null/unparseable/year<1900 as never-scanned).
#447: the flaky 'stops scan polling' test asserted synchronously after a fire-and-forget interval handler; wrapped the post-tick assertions in waitFor (no weakening). 20/20 green in a repeat loop.

Deviation to flag: the #409 issue author mildly preferred normalizing at the API read boundary (return null instead of MinValue). I steered this to a pure-SPA fix to avoid a DB migration for a priority:low bug — robust, but noting the deviation for a maintainer call.

Review: pure-SPA leaf — independent review skipped per skip rubric (stated). typecheck/lint/vitest green (23 tests).

fixes #409
fixes #447

**#409:** never-scanned local libraries rendered a bogus '12:00 AM' because the API serializes `DateTime.MinValue` as a truthy ISO string that `formatDateTime` happily parses. Added a client-side `hasScanned()` sentinel guard (treats null/unparseable/year<1900 as never-scanned). **#447:** the flaky 'stops scan polling' test asserted synchronously after a fire-and-forget interval handler; wrapped the post-tick assertions in `waitFor` (no weakening). 20/20 green in a repeat loop. **Deviation to flag:** the #409 issue author mildly preferred normalizing at the API read boundary (return null instead of MinValue). I steered this to a pure-SPA fix to avoid a DB migration for a priority:low bug — robust, but noting the deviation for a maintainer call. **Review:** pure-SPA leaf — independent review skipped per skip rubric (stated). typecheck/lint/vitest green (23 tests). fixes #409 fixes #447
timothy added 1 commit 2026-07-18 16:57:31 +02:00
fix(409,447): LibrariesScreen shows 'Never scanned' + stabilize flaky scan-poll test
Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 6s
Details
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Details
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 6s
Details
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m10s
Details
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 11s
Details
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 7s
Details
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 14m17s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 19m27s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details
25c8936bcb 
fixes #409
fixes #447

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
timothy commented 2026-07-18 17:00:14 +02:00
Author
Owner
Copy Link
Copy Source

Review-verdict: MERGEABLE @ 25c8936bcb
Pure-SPA leaf (#409 client-side sentinel guard + #447 waitFor test stabilization, 20/20 repeat-green). Independent review skipped per skip rubric — stated. Note: #409 uses a client-side fix vs the issue author's mild preference for API-boundary normalization (flagged in PR body for a maintainer call).

Review-verdict: MERGEABLE @ 25c8936bcb4275fe897b5aaea09a8d271f249e98 Pure-SPA leaf (#409 client-side sentinel guard + #447 waitFor test stabilization, 20/20 repeat-green). Independent review skipped per skip rubric — stated. Note: #409 uses a client-side fix vs the issue author's mild preference for API-boundary normalization (flagged in PR body for a maintainer call).
timothy merged commit b1521f9047 into main 2026-07-18 18:18:46 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ad-hoc
One-off / ad-hoc work not tracked by a dedicated issue
 api
REST API / HTTP endpoints
 bug
Something isn't working
 ci-cd
Build, test, deploy pipeline
 content
Channel content / schedules / playlists
 dependencies
Dependency updates (Renovate)
 enhancement
New feature or improvement
 frontend
ChicoryTV React SPA frontend
 in-progress
Claimed by an active session — do not pick up
 jellyfin
Jellyfin tuner / IPTV integration
 parked
Excluded from automatic queue pickup; work only when explicitly selected
 priority: high
priority: low
priority: medium
review
Adversarial review finding
 security
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate timothy (Timothy)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#451