ReplacePlaylistItemsHandler performed no name validation on rename. Added a .BindT(ValidateName) step using the StringValidation combinators (NotEmpty/NotLongerThan(50)), mirroring RenamePlaylistGroupHandler and matching CreatePlaylistHandler's rule exactly. Failure maps to 422 per api-conventions. 4 tests added (9/9 pass).
Review: write-path — independent cold review = MERGEABLE (one inherited nit: rename doesn't check name-uniqueness, same as its exemplar RenamePlaylistGroupHandler; deferred, not a regression).
`ReplacePlaylistItemsHandler` performed no name validation on rename. Added a `.BindT(ValidateName)` step using the `StringValidation` combinators (`NotEmpty`/`NotLongerThan(50)`), mirroring `RenamePlaylistGroupHandler` and matching `CreatePlaylistHandler`'s rule exactly. Failure maps to 422 per api-conventions. 4 tests added (9/9 pass).
**Review:** write-path — independent cold review = **MERGEABLE** (one inherited nit: rename doesn't check name-uniqueness, same as its exemplar RenamePlaylistGroupHandler; deferred, not a regression).
fixes #327
Review-verdict: MERGEABLE @ 48f7ceff62
Write-path. Independent cold review = MERGEABLE. Name validation mirrors RenamePlaylistGroupHandler/StringValidation, maps to 422, 9/9 tests. One inherited nit (no name-uniqueness check, same as its exemplar) deferred — not a regression.
Review-verdict: MERGEABLE @ 48f7ceff6272871405104b39086439eaac1ea098
Write-path. Independent cold review = MERGEABLE. Name validation mirrors RenamePlaylistGroupHandler/StringValidation, maps to 422, 9/9 tests. One inherited nit (no name-uniqueness check, same as its exemplar) deferred — not a regression.
Live-E2E PASSED (scripts/e2e-local.sh, real /api endpoints, machine-key auth). Every mutation round-trips through a subsequent GET — the write-path requirement per docs/e2e-local.md is satisfied. Proceeding to merge.
Live-E2E PASSED (scripts/e2e-local.sh, real /api endpoints, machine-key auth). Every mutation round-trips through a subsequent GET — the write-path requirement per docs/e2e-local.md is satisfied. Proceeding to merge.
timothy
merged commit f62ff0eebc into main2026-07-18 18:27:20 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
ReplacePlaylistItemsHandlerperformed no name validation on rename. Added a.BindT(ValidateName)step using theStringValidationcombinators (NotEmpty/NotLongerThan(50)), mirroringRenamePlaylistGroupHandlerand matchingCreatePlaylistHandler's rule exactly. Failure maps to 422 per api-conventions. 4 tests added (9/9 pass).Review: write-path — independent cold review = MERGEABLE (one inherited nit: rename doesn't check name-uniqueness, same as its exemplar RenamePlaylistGroupHandler; deferred, not a regression).
fixes #327
Review-verdict: MERGEABLE @
48f7ceff62Write-path. Independent cold review = MERGEABLE. Name validation mirrors RenamePlaylistGroupHandler/StringValidation, maps to 422, 9/9 tests. One inherited nit (no name-uniqueness check, same as its exemplar) deferred — not a regression.
Live-E2E PASSED (scripts/e2e-local.sh, real /api endpoints, machine-key auth). Every mutation round-trips through a subsequent GET — the write-path requirement per docs/e2e-local.md is satisfied. Proceeding to merge.