fix(463): bound the schedules "Active schedule" selector so it stops overlapping the header #465

Merged
timothy merged 1 commits from fix/463-schedule-select-width into main 2026-07-19 12:21:01 +02:00
Owner

Fixes the header-overlap on /app/schedules reported in #463.

Root cause

The "Active schedule" Select (SchedulesScreen.tsx:480) rendered at the component default fullWidth=true → .ctv-field-full { width: 100% }. In the flex .ctv-schedule-header that makes it demand the whole row, overlapping the title/counts block and the Add/Edit/Delete buttons.

Fix (pure-SPA/CSS)

  • fullWidth={false} so the selector sizes to content, bounded to 150–260px via style so a long schedule name can't re-widen it. The native <select> value truncates within the frame (.ctv-select { min-width: 0 }).
  • Regression test asserts the selector wrapper is not .ctv-field-full.

No API/DB change. SchedulesScreen.test.tsx 25 green; lint/typecheck clean; prod build OK. Visual confirmation (screenshot) to follow.

fixes #463

🤖 Generated with Claude Code

Fixes the header-overlap on `/app/schedules` reported in #463. ## Root cause The "Active schedule" `Select` (`SchedulesScreen.tsx:480`) rendered at the component default `fullWidth=true` → `.ctv-field-full { width: 100% }`. In the flex `.ctv-schedule-header` that makes it demand the whole row, overlapping the title/counts block and the Add/Edit/Delete buttons. ## Fix (pure-SPA/CSS) - `fullWidth={false}` so the selector sizes to content, bounded to **150–260px** via `style` so a long schedule name can't re-widen it. The native `<select>` value truncates within the frame (`.ctv-select { min-width: 0 }`). - Regression test asserts the selector wrapper is **not** `.ctv-field-full`. No API/DB change. `SchedulesScreen.test.tsx` 25 green; lint/typecheck clean; prod build OK. Visual confirmation (screenshot) to follow. fixes #463 🤖 Generated with [Claude Code](https://claude.com/claude-code)
timothy added 1 commit 2026-07-19 11:58:41 +02:00
fix(463): bound the schedules "Active schedule" selector so it stops overlapping the header
Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 5s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 14s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 8s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 9s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 13s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 15m24s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 19m38s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 20m56s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
df617a64c7
The header selector rendered at the Select default `fullWidth=true`, which applies
`.ctv-field-full { width: 100% }`. In the flex `.ctv-schedule-header` that made it
demand the whole row, overlapping/distorting the title block and Add/Edit/Delete
buttons. Pass `fullWidth={false}` (sizes to content) + bound it to 150–260px so a
long schedule name can't re-widen it; the native select's value truncates within
the frame (`.ctv-select { min-width: 0 }`).

Pure-SPA/CSS, no API/DB change. Regression test asserts the selector wrapper is not
`.ctv-field-full`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
Owner

Cold adversarial review — MERGEABLE-WITH-NITS

Independent cold review (fresh agent, review-only) of the diff. Verified: fullWidth={false} correctly drops .ctv-field-full { width:100% } (the exact overflow cause); style lands on .ctv-field-frame (a real flex box) so the 150–260px bound applies; .ctv-select { min-width:0 } truncates the value cleanly; the wrapped-width @media path is fine (the selector wraps to its own line instead of overlapping); and the regression test is non-vacuous (fails if fullWidth={false} is removed). No a11y regression.

Nits (cosmetic, no change): a very long schedule name ellipsizes in the closed control (full text visible when opened; minWidth 150 keeps it legible) — acceptable and strictly better than the prior full-row overlap. No docs owed (one-off style prop, not a convention change).

Review-verdict: MERGEABLE @ df617a64c7

## Cold adversarial review — MERGEABLE-WITH-NITS Independent cold review (fresh agent, review-only) of the diff. Verified: `fullWidth={false}` correctly drops `.ctv-field-full { width:100% }` (the exact overflow cause); `style` lands on `.ctv-field-frame` (a real flex box) so the 150–260px bound applies; `.ctv-select { min-width:0 }` truncates the value cleanly; the wrapped-width `@media` path is fine (the selector wraps to its own line instead of overlapping); and the regression test is non-vacuous (fails if `fullWidth={false}` is removed). No a11y regression. Nits (cosmetic, no change): a very long schedule name ellipsizes in the *closed* control (full text visible when opened; minWidth 150 keeps it legible) — acceptable and strictly better than the prior full-row overlap. No docs owed (one-off style prop, not a convention change). Review-verdict: MERGEABLE @ df617a64c70c715c4b2b32ea015b55f2d2123e22
timothy merged commit cc2968de15 into main 2026-07-19 12:21:01 +02:00
timothy deleted branch fix/463-schedule-select-width 2026-07-19 12:21:02 +02:00
Sign in to join this conversation.