test: make channel logo generator testable #53

2026-06-30T18:14:39+02:00

timothy commented

2026-06-30 18:14:39 +02:00

Summary

Add an injectable ChannelLogoGenerator constructor for explicit overlay/font paths while preserving the existing DI constructor and runtime default paths.
Add property-style logo tests that render with copied test assets and assert valid PNG format plus requested dimensions.
Cover a long channel name case without byte-exact or pixel-golden assertions.

Verification

LSP diagnostics on changed C# files: no diagnostics.
TDD red: focused test failed with CS1729 before the injectable constructor existed.
/usr/bin/env TZ=UTC dotnet test ErsatzTV.Core.Tests/ErsatzTV.Core.Tests.csproj --filter FullyQualifiedName~ChannelLogoGeneratorTests -v minimal passed 3/3.
dotnet build ErsatzTV.sln passed with 0 errors and known Scriban.Signed NU1903 warnings.
/usr/bin/env TZ=UTC dotnet test ErsatzTV.sln -v normal passed; visible summary reported 263/263 passed, with the same NU1903 warnings.
Adversarial review: no blocking correctness issues; addressed staging/line-ending hygiene before commit.

Refs #39

## Summary - Add an injectable `ChannelLogoGenerator` constructor for explicit overlay/font paths while preserving the existing DI constructor and runtime default paths. - Add property-style logo tests that render with copied test assets and assert valid PNG format plus requested dimensions. - Cover a long channel name case without byte-exact or pixel-golden assertions. ## Verification - LSP diagnostics on changed C# files: no diagnostics. - TDD red: focused test failed with `CS1729` before the injectable constructor existed. - `/usr/bin/env TZ=UTC dotnet test ErsatzTV.Core.Tests/ErsatzTV.Core.Tests.csproj --filter FullyQualifiedName~ChannelLogoGeneratorTests -v minimal` passed 3/3. - `dotnet build ErsatzTV.sln` passed with 0 errors and known `Scriban.Signed` NU1903 warnings. - `/usr/bin/env TZ=UTC dotnet test ErsatzTV.sln -v normal` passed; visible summary reported 263/263 passed, with the same NU1903 warnings. - Adversarial review: no blocking correctness issues; addressed staging/line-ending hygiene before commit. Refs #39

timothy added 1 commit 2026-06-30 18:14:39 +02:00

test: make channel logo generator testable

Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m13s

Details

Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m14s

Details

Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped

Details

8e6379a51b