docs(ersatztv skill): record the #510 no-logo-no-bug policy and deco seeding recipe #659

Merged
timothy merged 1 commits from docs/510-skill-logo-bug-policy into main 2026-07-26 22:41:56 +02:00
1 Commits
Author SHA1 Message Date
timothy b99ba68b4b docs(ersatztv skill): record the #510 no-logo-no-bug policy and deco seeding recipe
review-verdict/h10 Review-verdict: MERGEABLE @ b99ba68
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 20s
PR Gates / Docs update reminder (pull_request) Successful in 20s
PR Gates / decisions lifecycle (pull_request) Successful in 20s
Review verdict / Set review-verdict status (pull_request) Successful in 1s
PR Gates / Script tests (pytest) (pull_request) Successful in 30s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 9s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 9s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 9s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 9s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 8s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
The skill's Logo System section documented the #502/#525 chain but stopped
before #510, so it described a behavior that no longer holds and omitted the
one fact someone consulting it would most likely need: a channel with a
watermark configured but no usable logo now renders NO on-screen bug, from
every attachment point, and says so in the log.

Adds, all discovered while working #510:

- The unified policy plus the log strings to grep ("has no logo artwork",
  "no longer exists") before suspecting the ffmpeg pipeline.
- That the deco path alone used to render the generated-initials nameplate and
  that it genuinely worked, with #652 as the revival path -- otherwise a future
  reader finds the nameplate in the code history and assumes it was dead.
- The #653 carve-out: the song-progress overlay bypasses the resolver and is
  still unchecked, so "no usable logo means no bug" is a property of the
  selector, not of the whole app.
- That /iptv/logos/gen is unauthenticated while the rest of /iptv is not,
  because ConditionalIptvAuthorizeFilter is a class attribute on IptvController
  and that route lives on ArtworkController.
- The fully API-driven deco-watermark seeding recipe (watermarks -> decos/groups
  -> decos -> PUT decos/{id} -> PUT playouts/{id}/deco), which cost real
  discovery time this session, plus the reminder that branding is not testable
  through the troubleshooting-playback API.

Docs-only leaf change to one skill file; no code, no server-state effect.
Verified the YAML frontmatter still parses (name + description intact) since an
unquoted ": " there silently disables a skill.

refs #510 #652 #653
2026-07-26 22:23:24 +02:00