Files
ersatztv/scripts
timothy 226f132b1c fix(744,835): review round 1 — ref-class residual, retracted two-step, guard escapes
Two independent cold reviews (Codex GPT-5.6, and a fresh Opus reviewer in an isolated
worktree) both returned BLOCKED. All findings addressed:

- The "what this does not close" statement sorted by the `branches:` KEYWORD, which
  mis-sorts `docker-build.yml`: it has `branches: [main]` and would pass, yet also
  `tags: ['v*']` and `pull_request:`, both head-resolved on the same registry
  credential — and a tag push is explicitly outside `release.main-direct-push-disabled`,
  so it needs no dispatch at all. Restated over the REF CLASS a trigger admits, in the
  record's `rule:` and in ci-cd.md, and #853 updated to match.
- The recovery text offered "dispatch on `main` after the merge and bump the pin" as an
  alternative. It cannot work: `expected` is the last `docker/ci` commit, so a pin naming
  the workflow-only commit fails `ci-image-pin` and leaving the pin keeps consuming the
  old image. A `docker/ci/**` touch is the only remedy.
- `ci-image.yml`'s own ROLLOUT NOTE still described the retracted merge-then-follow-up-PR
  two-step, five lines below the trigger summary the change had updated.
- The guard: `uses: https://github.com/actions/checkout@v4` is a valid Gitea spelling and
  escaped both the walk and the text cross-check — canonicalised, and both spellings are
  now pinned in the negative control. Added two absence tests so the population's
  assumptions REPORT themselves rather than going blind: no tracked workflow below
  `.gitea/workflows/` (the direct-children derivation is shared with two sibling guards),
  and no local composite action (whose `action.yml` is invisible to both halves of the
  cross-check — the docstring had cited the wrong test for that case).
- `ci-image-pin` no longer claims to prove PUBLICATION: it compares git shas and never
  queries the registry, which matters more now that publishing is a human dispatch.
  Existence stays `toolchain-preflight`'s job.
- The `:latest` guard is now the SOLE protection on the one event that never exercised it
  (a dispatch selects any ref), and says so.
- Stale contracts: the credential-scoping record's `rule:` frontmatter and body still said
  15-of-16; the pin job's `::error::` still said "let ci-image.yml publish".

The `docker/ci/Dockerfile` comment fixes were made, reddened `ci-image-pin` (any byte
there re-points `expected`), and were reverted — the trap is now recorded in ci-cd.md and
the record, with both stale line ranges deferred to #854.

refs #744
refs #835
Decisions-Edit: yes
2026-08-27 20:31:56 +02:00
..
2024-01-15 10:29:07 -06:00
2024-01-16 13:28:46 -06:00