timothyandtimothy 884ac8a7e9 fix(756): extend the dropped-step guard to docker-build.yml's required jobs, where a drop is fail-OPEN (#768) ...

A `run:` body the runner declines to interpolate is dropped, and the job still
concludes `success` (#751). #751 fixed that in review-verdict.yml, where the
failure is fail-CLOSED. This closes the two places where it is fail-OPEN:
`Build & test (.NET)` and `EF migration integrity (SQLite + MySql)` are the
other two required contexts on `main`, so a dropped step there sends a required
check green having done no work.

Per-STEP markers, not per-job as proposed: a marker on the first step only
proves the job began, while the drop that costs something is `Test`, `Build` or
a migration replay. The trailing guard carries no `if:` — with a dozen steps,
`always()` would announce a false "these steps never executed" on every ordinary
red build; the default `success()` is correct because guard-skipped implies
job-red. Plus a ban on the raw `${{` opener in `test`, `migrations` and `build`,
which makes the class unreachable rather than merely caught. `build` is included
because its Smoke step runs AFTER the image is pushed.

Measured live on the build lane in both directions: probe #765 (drop caught,
sole failure in the job) and #766 (a failing continue-on-error step does not
skip the guard). 510 tests, 30 mutations killed across two harnesses, five cold
review rounds across two model families.

Residual tracked as #767: the `build` ban is review-time only, not fail-closed
on the release path.

fixes #756

Co-authored-by: Timothy <timothy@noreply.gitea.tblindustries.be>

2026-08-10 23:35:08 +00:00

..

fixtures

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

__init__.py

feat(521): decision-record parser (decisions_lib)

2026-07-21 02:58:58 +02:00

test_build_catalog.py

fix(603): close four defects found in adversarial review of the stale-after fields

2026-07-25 15:22:50 +02:00

test_check_review_verdict.py

fix(629): strip raw HTML blocks, and state where the hardening stops

2026-07-26 01:14:59 +02:00

test_ci_dropped_step_guard.py

fix(756): extend the dropped-step guard to docker-build.yml's required jobs, where a drop is fail-OPEN (#768)

2026-08-10 23:35:08 +00:00

test_decisions_lib.py

fix(688): make the n oracle dynamic; correct a tense that asserted false history

2026-08-04 22:35:00 +02:00

test_decisions_validate.py

fix(688): pin p95's inclusivity; drop a stale ratio and hedge the gap width

2026-08-04 23:07:15 +02:00

test_jq_preflight.py

test(648): close the mutation gaps round 5 found — two tests passed for the wrong reason

2026-07-26 22:21:07 +02:00

test_merge_consent_base_change.py

fix(632): validate status ROWS, not just the top-level array — the same swallow one level down

2026-07-26 23:38:14 +02:00

test_merge_consent_exemption.py

fix(706,707,711): fence the review-verdict write on the timeline retarget count

2026-08-03 21:41:16 +02:00

test_migration_equivalence.py

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

test_post_review_verdict.py

fix(632): fail closed when the head/base re-read itself fails

2026-07-26 23:16:35 +02:00

test_pr_changed_files.py

fix(756): extend the dropped-step guard to docker-build.yml's required jobs, where a drop is fail-OPEN (#768)

2026-08-10 23:35:08 +00:00

test_prepush_rebase_check_tag_exemption.py

fix(743): re-tense the third stale site, and pin the two surviving mutants

2026-08-06 00:10:45 +02:00