timothy
fba5233caf
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 11s
PR Gates / Docs update reminder (pull_request) Successful in 16s
PR Gates / decisions lifecycle (pull_request) Failing after 23s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m17s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 1m29s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m5s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 16m5s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 17m6s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
168 records -> docs/decisions/records/<area>/<topic>.md (163 active, 23 dirs) and docs/decisions/archive/<area>/<topic>.md (5 archived). The filename IS the key, so one-active-record-per-key becomes a filesystem property rather than a validator check, and supersession becomes a `git mv`. WHY: the monolith was a concurrency problem before an aesthetic one. A 3,900-line append target made parallel sessions collide -- PR #605 and PR #614 both hit append-vs-append conflicts during routine rebases, and hand-resolving those inside the corpus is exactly the operation the rationale-rewrite guard exists to police. HOW IT IS VERIFIED: a ~170-file diff cannot be meaningfully read, so correctness does not rest on reading it. The parser was taught BOTH formats first, so the body-diff guard parses the old form at the merge-base and the new form at head -- the migration validates itself, no bypass. The proof is a field-level equivalence harness: 168 records before and after, zero lost, zero gained, zero field mismatches, zero rationale bodies differing. Reviewers should scrutinise the harness; it is the actual evidence. What measuring caught that reading would not have: - ~500 lines sit OUTSIDE any record -- decisions.md's lifecycle schema and each topic file's preamble, mostly the only copy. Source files are kept and stripped, never deleted. They also cannot be filed per-area: topic files hold several areas and 4 of 23 areas span several files. - Archive discovery was a non-recursive glob; after the split it found ZERO archived records, surfacing as four bogus "supersedes points to unknown key" errors rather than an obvious failure. - ~32 live docs point into the corpus BY DATE, which the split dangles. Each stripped file now ends with a generated "Records formerly in this file" index, which also rescues the identical breadcrumbs in old issue comments. - decisions.md's "In this file:" list was 97 same-file anchor bullets that the split makes WRONG, not merely stale. Dropped; the generated index replaces them with links that resolve. The equivalence harness now runs against a checked-in FIXTURE, not the live corpus. The earlier version migrated the real tree, which made it a one-shot: the moment the migration landed there was nothing left to move and the tests failed for reasons unrelated to the code. A fixture keeps them testing the SCRIPT rather than the repo's current state. Keys preserved verbatim, warts included: `sched` (12) and `scheduling` (1) remain two directories for one concept. Renaming a key is not a move -- it changes identity, breaks the equivalence proof, and invalidates MemPalace's per-key drawers. Taxonomy normalisation is separate work. refs #610
3.2 KiB
3.2 KiB
key, title, status, since, supersedes, superseded-by, rule, signals, mechanics
| key | title | status | since | supersedes | superseded-by | rule | signals | mechanics |
|---|---|---|---|---|---|---|---|---|
| ci.format-gate-folder-mode | 2026-07-19 — The `format` gate runs `dotnet format whitespace . --folder`, not the full solution format (#469) | active | 2026-07-19 | none | none | The blocking `format` CI job (and matching pre-commit hook) runs `dotnet format whitespace . --folder --include <files>` instead of loading the full MSBuild/Roslyn solution, cutting the gate from ~480s to ~0.5s with unchanged whitespace/charset coverage. | dotnet format, folder mode, CI format gate · paths: `.gitea/workflows` format job, `.editorconfig` · issues: #469, #406, #311 | `dotnet format whitespace . --folder --verify-no-changes --include <files>` |
The blocking format CI job (and the matching Husky pre-commit hook) verify changed .cs files with
dotnet format whitespace . --folder --verify-no-changes --include <files> instead of the previous
dotnet format ErsatzTV.sln --no-restore --verify-no-changes --include <files>.
- Why.
--includenarrows which files are checked, never what gets loaded. The full recipe loaded the whole ~10-project MSBuild workspace and built a Roslyn compilation per project before checking a single line — a fixed cost independent of how few files changed. Measured ~480s for a whole-solutiondotnet formatlocally (matching the issue's "7+ min").--foldertreats the tree as a plain folder of files and skips MSBuild/Roslyn entirely: ~0.5s, and it needs nodotnet restore, so the job's NuGet-cache + Restore steps were deleted. It also drops the job's ~3.95 GiB Roslyn heap (the #406 memory note aboutformatnot shrinking is now moot). - Coverage is unchanged, not merely "good enough". Folder mode reads
.editorconfigand enforces exactly the two things this gate exists for — whitespace (indent/EOL/trailing/final-newline) and charset (no UTF-8 BOM). Proven non-vacuous: exits non-zero witherror WHITESPACEon an injected trailing-whitespace line anderror CHARSETon a prepended BOM; exits 0 on a clean file. What it drops is the style/analyzer pass — but the full gate never enforced that either: a probe injecting awarning-severity naming violation (local_constantsnotALL_UPPER) passed the full solution format (exit 0): the only.editorconfigrule above:suggestion/:noneseverity is that one naming rule, and naming violations have nodotnet formatbatch code-fixer, so--verify-no-changesreports no change regardless of severity. The analyzers that must block (NU1904,S3981) are enforced at compile time viaWarningsAsErrorsinDirectory.Build.props, never by this job. - Fix command for a violation:
dotnet format whitespace . --folder --include <files>. The fulldotnet format ErsatzTV.sln --include <files>is a superset (also applies style) and still works, so existing muscle memory and the #311 lore'sdotnet format --includeguidance are not broken. - Lane left on
ubuntu-latest. The job is now seconds-long and low-memory, so it could move to a lighter lane, but that re-touches the per-lane memory-cap accounting (#406/#604) and is a server-management capacity call — deliberately out of scope here.