Files
ersatztv/scripts/tests
timothy 2734536a3a fix(744,835): review round 3 — the filter is REF-SUPPLIED, so this closes drive-by only
Round 3 (two independent cold reviews, both BLOCKED, no blocker/high between them
except one guard escape) found the security framing itself overstated.

**The `branches:` filter is loaded from the pushed ref, like every other line in the
file.** A branch whose `ci-image.yml` deletes the filter fires exactly as before, on the
same runner, with the same credential. The mechanism this change is built on — "Gitea
resolves a push workflow's definition from the pushed ref" — applies to the fix as much as
to the hole, and three bolded sentences said "closes that route" without noticing. What is
actually closed is the DRIVE-BY case: publication as a side effect of an ordinary push of a
legitimate `docker/ci` change, no deliberate act anywhere. That is real and worth closing,
and it is not a boundary against someone who intends to run their own YAML. Corrected in
the workflow, ci-cd.md and the record's `rule:` and bullet 1, with an explicit "do not cite
this record as that boundary"; #853 updated to lead with it, and a scope note posted on
#744 because the issue body frames the fix more strongly than it delivers.

**Three more spellings of `actions/checkout` escaped both halves of the guard**, in the
same class as rounds 1 and 2: a `.git` suffix (which is how Gitea itself writes the clone
URL), `@`-userinfo before the host (splitting on the FIRST `@` stripped the host, not the
version), and a doubled slash. Canonicalisation now rsplits, drops a `.git`, and absorbs
empty segments; all seven spellings are pinned. Two more absence tests so the remaining
boundaries report themselves instead of going blind: no job delegates to a reusable
workflow (both halves would see zero and AGREE, so the count cross-check cannot report it),
and nothing tracked under `.github/workflows` — which Gitea reads only when
`.gitea/workflows` is absent, an unprobed precedence rule, in a directory that already
exists here.

Also: "had to land alone" / "forced this change to land alone" still carried the necessity
premise round 2 retracted — landing alone was the cheaper option, not the only one;
`ci-image-pin` was called "blocking" as though branch protection required it (it does not
— the block comes from the merge-consent hook reading the COMBINED status); the pin step
was still named "Verify the pin matches the last-published image" while doing no registry
query at all; ci-cd.md still documented `expected` as `docker/ci/**` or `ci-image.yml`;
`release.main-direct-push-disabled` carried its own stale 15-of-16 count; the ordering
constraint said "below" where "in that commit or below it" is correct; and the #854
deferral undercounted the stale Dockerfile comments at one when there are two.

refs #744
refs #835
Decisions-Edit: yes
2026-08-27 21:34:11 +02:00
..