Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
90 lines
3.5 KiB
C#
90 lines
3.5 KiB
C#
using System.Threading.Channels;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Locking;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class UpdateTraktListHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
IEntityLocker entityLocker,
|
|
ChannelWriter<IBackgroundServiceRequest> workerChannel)
|
|
: IRequestHandler<UpdateTraktList, Option<BaseError>>
|
|
{
|
|
public async Task<Option<BaseError>> Handle(UpdateTraktList request, CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
|
|
Option<TraktList> maybeTraktList = await dbContext.TraktLists
|
|
.Include(tl => tl.Playlist)
|
|
.SelectOneAsync(t => t.Id, t => t.Id == request.Id, cancellationToken);
|
|
|
|
foreach (TraktList traktList in maybeTraktList)
|
|
{
|
|
traktList.AutoRefresh = request.AutoRefresh;
|
|
traktList.GeneratePlaylist = request.GeneratePlaylist;
|
|
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
|
|
if (request.GeneratePlaylist)
|
|
{
|
|
if (traktList.PlaylistId is null)
|
|
{
|
|
PlaylistGroup traktListGroup = await dbContext.PlaylistGroups
|
|
.Filter(pg => pg.IsSystem)
|
|
.FirstOrDefaultAsync(cancellationToken);
|
|
|
|
var playlist = new Playlist
|
|
{
|
|
IsSystem = true,
|
|
Name = $"{traktList.User}/{traktList.List}",
|
|
PlaylistGroupId = traktListGroup.Id,
|
|
PlaylistGroup = traktListGroup
|
|
};
|
|
|
|
traktList.Playlist = playlist;
|
|
|
|
await dbContext.Playlists.AddAsync(playlist, cancellationToken);
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
}
|
|
|
|
if (entityLocker.LockTrakt())
|
|
{
|
|
try
|
|
{
|
|
// post-commit side effect runs on CancellationToken.None so a late request
|
|
// cancellation can't abort it after the commit landed (#254)
|
|
await workerChannel.WriteAsync(new MatchTraktListItems(traktList.Id), CancellationToken.None);
|
|
}
|
|
catch
|
|
{
|
|
// the background handler only unlocks when it receives the message; if the
|
|
// enqueue fails after we acquired the lock, release it here or it is held forever.
|
|
entityLocker.UnlockTrakt();
|
|
throw;
|
|
}
|
|
}
|
|
}
|
|
else if (traktList.PlaylistId is not null)
|
|
{
|
|
// delete playlist
|
|
await dbContext.Playlists
|
|
.Where(p => p.Id == traktList.PlaylistId)
|
|
.ExecuteDeleteAsync(cancellationToken);
|
|
}
|
|
}
|
|
|
|
return Option<BaseError>.None;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
return BaseError.New(ex.ToString());
|
|
}
|
|
}
|
|
}
|