Both round-2 cold reviews returned BLOCKED. The most important finding is that a claim
this change made three times over was simply wrong.
**"Removing the self-path is FORCED" is false.** The argument was that under
`branches: [main]` a self-triggering path can only publish after the merge. It cannot
publish by PUSH — but the retained branch `workflow_dispatch` publishes it fine: dispatch
the branch at the ci-image.yml commit, then pin it, and `ci-image-pin` resolves both to
that commit and passes. So keeping the self-reference is workable, and the decision rests
entirely on price, not necessity: keeping it charges a full ~2GB publish plus a five-pin
bump for EVERY edit to that file, comments included, redone after every rebase — the cost
that reverted #697 and forced this to land alone — against the cost of dropping it, a
recipe change living only in ci-image.yml that never republishes. The second was chosen
because that file is edited far more for triggers and comments than for build recipe.
Restated as a decided tradeoff, with both prices, in the record, ci-cd.md and both
workflow comments. #744's Done-when asks for the tradeoff to be DECIDED rather than
asserted away; a false necessity claim was the opposite of that.
**The guard had two more escapes of the class round 1 closed for URLs.** A Gitea action
host is not required to contain a dot (`http://your-git-server/actions/checkout@v4` is the
documented self-hosted spelling), and the forge is case-insensitive on owner/repo
(`Actions/Checkout@v4` runs the real checkout). Both escaped the walk AND the text scan
identically, so the count cross-check agreed and the guard reported clean. Replaced the
host heuristic with last-two-path-segments and made both halves case-insensitive; all
three spellings are pinned in the negative control.
**A new stale-but-green state was reachable by following the documented remedy literally.**
The dispatch builds HEAD's copy of every file, so a `ci-image.yml` recipe change committed
AFTER the `docker/ci` commit publishes an image built by the old recipe while the pin and
`expected` both name the `docker/ci` commit — green over an image the merged recipe would
not produce. Step 1 now states the ordering.
Also: the credential-scoping record's `rule:` frontmatter still said #744 was tracked-open
and still asserted the mechanism this change removes, contradicting its own body — round 1
fixed the 15-of-16 clause inside that same string and stopped, a sweep by keyword rather
than by concept. `ci-image-pin`'s comment still said a docker/ci PR "publishes a NEW
image". Restored the #445 attribution the recovery rewrite dropped. Renamed the composite
-action test to say what it asserts (that none EXISTS), and filed #855: nothing
mechanically couples `ci-image.yml`'s `push.paths` to `ci-image-pin`'s `expected` now that
the shared self-reference is gone.
refs #744
refs #835
Decisions-Edit: yes