Files
ersatztv/scripts/tests
timothy eb9cc6cb31
Build ErsatzTV Image / CI toolchain image resolves (pull_request) Successful in 9s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 25s
Review verdict / Set review-verdict status (pull_request_target) Successful in 18s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 11m27s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 8m7s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
review-verdict/h10 Review-verdict: MERGEABLE @ eb9cc6c (base: main)
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 8m59s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 9s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 5s
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 10s
PR Gates / Docs update reminder (pull_request) Successful in 16s
PR Gates / decisions lifecycle (pull_request) Successful in 21s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 15s
PR Gates / Script lint and tests (ruff + pytest) (pull_request) Successful in 18m47s
fix(870): round-2 review — cost arithmetic was wrong twice, and one fixture proved nothing
Cold re-review of the fix commit (Opus, isolated worktree; the cross-family arm was unavailable,
Codex having hit its usage quota mid-session). No Blocker, no High on the code — it executed the
walk and every mutant of it. Every finding was in prose, cost accounting, or a test that did not
discriminate. All are addressed here.

COST ARITHMETIC, WRONG TWICE, BOTH NOW MEASURED RATHER THAN REASONED.

- Worst-case sleeps: the comment said 19, reasoning that the last page could not sleep. It can.
  Executing the walk against scripted responses gives 40 requests and 20 sleeps.
- Wall clock: the comment said ~335s, on the premise that only the last page can pay two timeouts.
  That bounds TIMEOUTS, not elapsed time — attempt 1 can burn its full 15s and attempt 2 still
  succeed slowly, so the page costs ~31s and the walk continues. The pessimum is 20x(15+1+15) =
  620s per walk, ~21min across the exempt path's three, and the job has no `timeout-minutes`.
  Stated rather than tuned, because the direction is the justification: the predecessor had no
  timeout at all. And it is bounded HERE only — `page_statuses` is still unbounded and runs in the
  same post-POST window, so the "a hang leaves the green standing" mode remains reachable there.

TWO COSTS THE CHANGE DID NOT STATE, now measured on this machine:

- The suite roughly doubled. `test_pr_changed_files.py`: 202s -> 474s (286 -> 294 tests,
  `-p no:randomly`, 528383cf3 vs this branch), because every fence fixture now drives 20 stub
  requests per walk instead of 2. `testing.mutation-claims-are-executed` carried a `~4min
  script-tests` figure measured before this; it is dated there rather than left to rot.
- The exemption `success` is live from its POST until the post-write repair, and the walk in
  between went from ~2 requests to 20. The comment documenting that window was written when it was
  two round trips.

A FIXTURE THAT PROVED NOTHING, caught by running the mutant it claimed to kill. The retry's
coverage of a non-array BODY was pinned by a fixture serving a 502 HTML page — but jq fails on
that, `|| kind=""` fires, and it takes the same path as a transport error. Narrowing the retry to
`if [ -n "$kind" ]` passed it. The shape that discriminates is a well-formed JSON OBJECT, which is
what this Gitea actually returns on an error (measured: `?since=NOTATIME` returns an object). Under
the narrowing an error object ends the retry and is then refused by the `case`, costing the
exemption. Fixture corrected, mutant now red on `[body]` and green on `[transport]` — which is the
point of parameterising over both.

PROSE, the same class the previous round removed six times:

- The workflow stated the attacker's cost two ways 45 lines apart ("50 rows before, ~1000 now"
  against "50 comments either way"). Neither was right: the 50-row filtered block is unchanged, but
  the timeline it must sit in grows from ~100 rows to over 1000, and on their own PR the padding is
  the attacker's to supply. Stated once now, in one unit, in all five places.
- The record's residual intro said the second residual "was closed by #870" directly above a
  heading reading "NARROWED ... not closed".
- "No terminator on this endpoint can do better" dropped both of the record's hedges. It is not a
  proof that none could exist: `?limit=49&page=21` reaches offsets 980..1028 with page edges that
  do not coincide with a 50-row walk's. Strictly better, still not a terminator.
- Retired vocabulary swept: two sites still described trust as "reached a validated empty page",
  and one listed "a non-array body" as untrusted three lines from the paragraph explaining that a
  bare `null` IS the accepted empty page.
- The retry's break set and the `case` arms are two enumerations of {array, null} whose agreement
  is what makes the stale-`kind` path harmless. Nothing said they must stay in sync; now it does.

DELIBERATELY NOT DONE: no `test_MUTATION_*`-named fixture for the new clauses. The convention is for
clauses disarmed in place via `_run_classify(mutate=...)`; these are page-LAYOUT properties, covered
by behavioural fixtures that were each mutation-witnessed red (7 of 7, independently re-measured by
the reviewer). Naming them for the convention would not add coverage.

Full suite green.

Fixes #870
Refs: #803, #706, #664, #751, #893
Decisions-Edit: yes
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-30 12:17:07 +02:00
..