fix(617): correct two stale logo claims carried in from both copies
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 10s
review-verdict/h10 Awaiting review verdict for e7ae919
PR Gates / Docs update reminder (pull_request) Successful in 12s
Review verdict / Set review-verdict status (pull_request) Successful in 3s
PR Gates / decisions lifecycle (pull_request) Successful in 17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m54s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 8s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 17m24s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 17m42s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped

Both copies still described pre-fix behavior:
- "External URL logos work for M3U but NOT for watermark burn-in (code
  checks File.Exists())" — the WatermarkSelector File.Exists gate was
  removed in #502 (ffmpeg.external-logo-graphics-engine); logos are cached
  at save time (graphics.channel-logo-caching).
- "M3U tvg-logo URLs hardcode http://localhost:8409" — #340 added the
  optional iptv.base_url advertised base URL (iptv.base-url).
This commit is contained in:
2026-07-26 00:42:22 +02:00
parent 2d6f78e379
commit e7ae919959
+12 -2
View File
@@ -421,8 +421,18 @@ Consumers reach ETV **only through Dispatcharr** (`ErsatzTV → Dispatcharr →
8. Run `fix_logos.py` to push logo to Jellyfin
### Logo System
- External URL logos work for M3U but NOT for watermark burn-in (code checks `File.Exists()`)
- M3U `tvg-logo` URLs hardcode `http://localhost:8409` — Jellyfin can't fetch these from inside its container. Fix by downloading logos from ETV and base64-uploading to Jellyfin (see `docs/Docker/ErsatzTV.md` for script)
- **External-URL logos now work for the on-screen bug too** — fixed in ersatztv#502 (2026-07-20,
`ffmpeg.external-logo-graphics-engine`). The old claim that they work for M3U but not watermark
burn-in described a `WatermarkSelector` `File.Exists()` gate that is gone; an external logo is
fetched, decode-budget-validated and stored in the image cache at **save** time
(`graphics.channel-logo-caching`), so the render path never fetches over HTTP and a bad URL fails
the save with a 422.
- **M3U/XMLTV absolute URLs are no longer stuck on the request-derived host.** They used to bake in
whatever host fetched the feed (the historical `http://localhost:8409` symptom, Gitea #1/#171),
which Jellyfin can't resolve from inside its container. Set the optional advertised base URL —
`GET`/`PUT /api/v1/settings/iptv` (`iptv.base_url`, ersatztv#340, `iptv.base-url`) — to pin them to
a fixed public origin; unset falls back byte-identical to the old behavior. The base64-upload
workaround in `docs/Docker/ErsatzTV.md` is only needed if that setting is left unset.
- `logo_XX.png` files in the logos root dir are HTML garbage (broken downloads), not actual logos — ignore them
### Other