docs(handoff): lessons from #242 — re-review the fix commit before closing; disabled={saving} SchedulesScreen convention
Build ErsatzTV Image / Docs update reminder (push) Has been skipped
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (push) Successful in 3m48s
Build ErsatzTV Image / Build & test (.NET) (push) Successful in 6m32s
Build ErsatzTV Image / Build & push image (amd64) (push) Successful in 5m32s

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-07-11 13:16:39 +02:00
co-authored by Claude Fable 5
parent eba22ce679
commit ea0eb0ab76
+13
View File
@@ -162,3 +162,16 @@ HARD CONSTRAINTS:
wholesale wedged the scan button disabled-until-reload for short scans; both fork + Codex caught
it. Keep a bounded version, re-scoped honestly. When an issue says "delete X", enumerate every
behavior X provided before deleting.
- **Re-review the FIX COMMIT, not just the initial PR diff, before closing** (2026-07-11, #242,
user-surfaced): the pre-fix review is only half the loop — the fix commit is new code no
independent reviewer has seen. Here the first fix (gate Edit on `saving`) only PARTIALLY closed
the in-flight-save clobber class; a Codex re-review of the fix commit caught that **Delete** was
the one schedule-switch path (`applySwitch`) still missing the guard. Fold a scoped re-review
(Codex if quota, else a fork) over the fix commit into the close protocol; loop until a clean
MERGEABLE verdict or an explicit acceptable-defer (file a tracked issue for the deferral, as #248
here). Cheap relative to shipping a half-fix that reopens the issue.
- **`disabled={saving}` is the SchedulesScreen convention for "no schedule-switch/mutation mid-save"**
(2026-07-11, #242): the Select + `guardedSwitch` already guard `saving`; Edit and Delete must too
— Delete switches schedules via `applySwitch`, and a stale items PUT resolving after the switch
clobbers the next schedule's draft. When adding any control that can switch the active schedule or
reopen the editor, gate it on `saving` (and, for the editor, on the dirty draft).