2881 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
timothyandCodex	8f90cea5cc	feat(analyzers): enable incremental latest-All enforcement ... Centralize SDK and threading analyzers, baseline the .NET 10 All rule inventory at suggestion severity, and promote S3981 repo-wide. Fix the always-true worker count predicate and cover the idle/active branches. Fixes #15 Co-Authored-By: Codex <codex@openai.com>	2026-07-16 21:52:27 +02:00
timothy	9938d9a6cd	Merge pull request '#340: configurable advertised IPTV base URL for M3U/XMLTV' (#374)	2026-07-16 19:51:27 +00:00
timothyandClaude Opus 4.8	dd273fbbb2	docs(202-e2e): record completed Plex real-server pin-flow validation ... Completes the outstanding Plex flow in the #202 post-merge integration checklist against a disposable test Plex Media Server: pin-flow auth, server/library discovery (the 2026-07-13 gap that returned servers:[]), sync-preference persistence, and sign-out cleanup all passed. Records exact API state evidence and the test-admin credential reset. fixes #333 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 21:39:16 +02:00
timothyandClaude Opus 4.8	27d01db265	fix(iptv): XML-escape advertised base URL in XMLTV guide output (#340 review) ... Independent review found that AdvertisedBaseUrl.TryParse accepts a path prefix containing '&' (a legal URL-path char kept out of uri.Query), but GetChannelGuideHandler substituted {RequestBase} raw into pre-built XML written unescaped — so a configured base like https://host/a&b emitted a bare '&', malforming the entire XMLTV guide (clients reject the document). Escape the substituted base with SecurityElement.Escape before the raw replace, mirroring how {AccessTokenUri} is already pre-escaped (&amp;). No-op for normal URLs (goldens unchanged); M3U output is untouched (M3U isn't XML). Adds a regression test asserting '&' → '&amp;' in the guide. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 21:08:42 +02:00
timothyandClaude Opus 4.8	3bc8192d3b	feat(iptv): add configurable advertised base URL for M3U/XMLTV (fixes #340) ... ErsatzTV built every absolute M3U/XMLTV URL from the incoming request's Scheme/Host/PathBase, so a client fetching via a host that downstream consumers can't resolve (e.g. Dispatcharr over Docker DNS → Kodi) baked that internal host into programme-image/stream URLs. Add an optional advertised IPTV base URL, backed by the existing ConfigElement key/value store (key `iptv.base_url`, no EF migration): - Central pure Core helper `AdvertisedBaseUrl` (TryParse/Resolve): validates absolute http(s), no credentials/query/fragment, preserves port + path prefix, normalizes trailing slash. Blank/invalid falls back to the request-derived values, so unset output is byte-identical. - Resolved inside `GetChannelPlaylistHandler` (M3U guide/logo/stream) and `GetChannelGuideHandler` (both XMLTV {RequestBase} sites) — controllers stay thin, golden tests untouched. - New `iptv` settings group: GET/PUT /api/v1/settings/iptv (blank clears, malformed → 422) + a new IPTV section on the SPA Settings screen. - Scoped to M3U + XMLTV; HDHomeRun deliberately out of scope. Distinct from ETV_BASE_URL (which only sets ASP.NET PathBase). Tests: AdvertisedBaseUrl unit tests (override/fallback/port/path/invalid), handler override tests for both generators, settings controller + handler tests, SPA client + screen tests. Docs: m3u-xmltv, decisions, domain-model, regenerated OpenAPI v1.json + v1.d.ts + endpoint-index. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 21:08:42 +02:00
timothy	de16a7c066	Merge pull request 'chore(deps): update dependency jetbrains.resharper.globaltools to 2025.3.4.1' (#329) from renovate/jetbrains.resharper.globaltools-2025.x into main	2026-07-16 18:47:04 +00:00
timothy	be85a462a4	Merge pull request 'chore(deps): update dependency humanizer.core to 3.0.10' (#328) from renovate/humanizer-monorepo into main	2026-07-16 18:38:12 +00:00
timothy	95d58f3b69	Merge branch 'main' into renovate/jetbrains.resharper.globaltools-2025.x	2026-07-16 18:35:14 +00:00
timothy	3654fad163	Merge pull request 'ci(coverage): collect code coverage and publish a summary (refs #15)' (#370) from feat/15-ci-coverage into main	2026-07-16 17:29:34 +00:00
timothy	9f0bb65fb4	docs(queue): exclude parked selector candidates (#372) ... Refs #237	2026-07-16 17:25:10 +00:00
timothy	72d47ef052	fix(api): protect local library path details (#371) ... Fixes #334	2026-07-16 17:16:51 +00:00
timothyandClaude Opus 4.8	e78aa01c05	ci(coverage): exclude generated EF migrations to stop coverage OOM (exit 137) ... The shared Build & test job OOM-killed (exit 137) with coverage enabled: the whole-solution Architecture.Tests process instruments both EF migration folders (~2.59M generated lines vs ~200k authored), ballooning coverlet's in-memory hit-count arrays past the runner's limit. Add coverlet.runsettings excluding **/Migrations/*.cs (+ generated/compiler attributes) and pass it via --settings on the Test step. This cuts the instrumented surface ~126x (2,510,185 -> 19,963 coverable lines in the Architecture.Tests process, verified locally) and makes the reported percentage reflect authored code. Documented in docs/ci-cd.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 19:03:54 +02:00
timothyandOpenAI Codex	0c6e8fab01	docs(queue): exclude parked selector candidates ... Refs #237 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 18:58:44 +02:00
timothyandOpenAI Codex	fe4706474e	test(api): assert effective local library auth ... Refs #334 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 18:54:57 +02:00
timothyandClaude Opus 4.8	a886fd2824	ci(coverage): make ReportGenerator install idempotent + pinned (review follow-up) ... Cold-review should-fix on PR #370: `dotnet tool install` errors under set -e if the tool is already present (retried step / cached runner image), which would silently degrade the continue-on-error summary step to a no-op. Use `dotnet tool update` (install-or-update) pinned to 5.5.10 for reproducible output. Also order coverlet.collector after CliWrap to keep the ItemGroup alphabetical (nit). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 18:49:28 +02:00
timothyandOpenAI Codex	489956b167	fix(api): protect local library path details ... Fixes #334 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 18:49:03 +02:00
timothyandClaude Opus 4.8	2090f7865c	ci(coverage): collect code coverage and publish a summary (refs #15) ... #15 scope item 4 ("collect with coverlet and publish a summary; decide on a floor later"). coverlet.collector was already referenced by four of the six test projects but the CI Test step never passed --collect and nothing summarized the result. - Add coverlet.collector to ErsatzTV.Core.Tests and ErsatzTV.Tests so coverage is uniform across all *.Tests projects. - CI Test step now runs --collect:"XPlat Code Coverage" --results-directory ./coverage, then a best-effort Coverage summary step merges the per-project Cobertura reports with ReportGenerator (TextSummary to the log, MarkdownSummaryGithub to the job step summary). No floor is enforced yet; continue-on-error keeps it purely informational. - gitignore /coverage/; document the step in docs/ci-cd.md (test job). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 18:45:32 +02:00
timothy	5c1d2f63fa	Merge pull request 'docs(queue): cascade selector through priority tiers' (#369) from codex/237-cascading-selector into main ... docs(queue): cascade selector through priority tiers (#369)	2026-07-16 14:14:01 +00:00
timothyandOpenAI Codex	e8580f4a84	docs(queue): cascade selector through priority tiers ... Refs #237 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 16:02:03 +02:00
timothy	ca5ac94466	Merge pull request 'fix(api): report direct streams as on air' (#368) from codex/99-direct-onair into main ... fix(api): report direct streams as on air (#368)	2026-07-16 13:14:32 +00:00
timothyandOpenAI Codex	d1a52eaa8b	docs(api): use versioned channel routes ... Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 15:03:53 +02:00
timothyandOpenAI Codex	7dee5194f4	fix(api): report direct streams as on air ... fixes #99 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 14:57:45 +02:00
timothy	ee044ab271	Merge pull request 'fix(web): coherent, recoverable Plex authorized-but-no-servers state (#345)' (#366) from fix/345-plex-empty-servers into main ... Merge PR #366: fix(web) coherent, recoverable Plex authorized-but-no-servers state (#345) Separates Plex authorization (stored token) from connection (discovered servers) so the authorized/unlocked/empty-servers state is coherent and recoverable (offers Sign out, does not claim a connection). Gates the empty-servers messaging on a released lock so it does not fire during discovery. fixes #345	2026-07-16 12:36:52 +00:00
timothy	6532929cf2	fix(web): gate Plex authorized-no-servers messaging on released lock ... Adversarial review of the initial fix found that authorizedNoServers = isAuthorized && !hasServers ignored isLocked. Because boot.state updates on every poll observation, the "no eligible servers — sign out and retry" subtitle + summary rendered during the normal `finalizing` window (locked, authorized, no servers yet) alongside the "discovering your Plex servers…" status — and during `budget-exhausted` (large first sync still holding the lock, polling stopped, Sign out enabled) it urged the user to sign out mid-sync. That reintroduced the contradictory-state class the PR fixes. Gate the empty-servers presentation on !isLocked so it only appears at the genuine released-lock terminal. Add regression coverage: the pin-flow test now passes through the finalizing cell asserting the empty-servers messaging is absent while locked, plus a budget-exhausted-while-locked case. Both new guards were confirmed to fail on the ungated code (negative control). Refs #345	2026-07-16 14:29:47 +02:00
timothy	0f0a0d7fe5	fix(web): coherent, recoverable Plex authorized-but-no-servers state ... A real Plex pin flow reached isAuthorized:true, isLocked:false, servers:[] (a Plex account that owns/has been granted no eligible servers). The SPA then showed contradictory state: the pin-flow status claimed "Connected to Plex." while the Connection card said "Not signed in.", offered Sign in, and hid Sign out — so the stored authorization could not be removed through the UI. Root cause: PlexSourceScreen conflated authorization (a stored token, isAuthorized) with connection (a discovered server, servers.length > 0) by deriving everything from `connected = servers.length > 0`, and evaluatePinFlow returned `success` ("Connected to Plex.") for any released-lock authorized observation regardless of server count. Fix (pure SPA; sign-out endpoint already works with empty servers): - pinFlowPoll: add a distinct `authorized-no-servers` terminal status and a `hasServers` observation field; the released-lock branch now yields success only when a server was discovered, else authorized-no-servers with an honest message that distinguishes authorization from discovery. - PlexSourceScreen: gate Sign in vs Sign out on `hasPlexAccount` (isAuthorized || hasServers) instead of the server count, so an authorized account can always sign out; add a subtitle + explanatory summary for the authorized/empty state; keep the Servers card gated on actual servers. - Regression tests: the authorized/unlocked/empty transition (pin-flow and fresh-reload paths) and sign-out from that state. fixes #345	2026-07-16 14:15:45 +02:00
timothy	572066157e	Merge pull request '#365' from docs/handoff-selector-terminal into main ... docs: make queue selection non-terminal Fixes #364	2026-07-16 12:13:05 +00:00
timothyandOpenAI Codex	b39c3b7bb0	docs: make queue selection non-terminal ... Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 14:00:16 +02:00
timothyandClaude Opus 4.8	0d7803079c	ci: add advisory functional-E2E curl harness (fixes #299) ... Codify the manual live-E2E curl flows sessions have been re-running by hand into a CI regression net: a new `functional-e2e` job boots the app from source (via scripts/e2e-local.sh, parameterized for Release) and drives scripts/ e2e-functional.sh against it. First-cut contracts (all curl-only, deterministic, no seeded media/ffmpeg/browser): - legacy->SPA redirect sweep + the /api,/artwork never-redirect exemption - auth/CSRF/security-stamp flow (setup-claim, read-gate, CSRF, login, logout+revoke) - library-scan status contract (404/202/scan-status) - optimistic-concurrency If-Match/412 round-trip Advisory by design (separate job, not a `build` dependency, not a required check) so a functional-E2E flake can't block the unit-test gate; promote once proven, mirroring the migrations-job rollout. SQLite default -> no DB service. Deferred to #299 follow-ups (need scanner+seeded media or a browser to be deterministic): the racy 409 re-trigger, playout-build lock 409, Playwright UI flows. Assertions verified 30/30 green against a real Release-built instance; caught /artwork/* returning 400 (not the 404 a static read suggested). Docs updated same PR: docs/ci-cd.md (new job), docs/e2e-local.md (harness), docs/decisions.md (append-only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-16 13:49:33 +02:00
timothy	82467f188b	Merge pull request '#361' from feat/247-shell-routing into main ... refactor(web): extract ChicoryTV shell and routing Closes #247	2026-07-16 11:42:19 +00:00
timothyandOpenAI Codex	947c8aacd8	test(web): restore App composition smokes ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-16 13:30:44 +02:00
timothyandOpenAI Codex	bd84593cd1	test(web): colocate screen behavior coverage (#247) ... Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:51:35 +02:00
timothyandOpenAI Codex	805ca026c4	docs(web): define shell and action ownership ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:51:32 +02:00
timothyandOpenAI Codex	44f4db5a6d	test(web): cover extracted shell contracts ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:51:23 +02:00
timothyandOpenAI Codex	30565145cd	test(web): harden primary-action ownership regressions ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:37:36 +02:00
timothyandOpenAI Codex	ce5aaa8706	refactor(web): extract app shell and routing ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:34:19 +02:00
timothyandOpenAI Codex	0416c00f96	refactor(web): replace primary-action events with context ... Refs #247 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 22:33:16 +02:00
timothyandOpenAI Codex	3876809a83	chore(web): clean up App imports after screen extraction ... Refs #246 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 21:51:42 +02:00
timothyandOpenAI Codex	e9fe12d1fd	refactor(web): extract Guide screen ... Move Guide rendering, timer and clipping helpers, and detailed behavior tests into a screen-owned module while retaining only shell composition coverage in App. Refs #246 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 21:49:56 +02:00
timothyandOpenAI Codex	bceffef856	refactor(web): extract Dashboard screen ... Move Dashboard rendering, health and on-air helpers, and detailed behavior tests into a screen-owned module while retaining only shell composition coverage in App. Refs #246 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-15 21:16:40 +02:00
timothy	ecde59be32	docs(queue): record cheap-worker launch config (#356) ... Merge the reviewed, green documentation update. Fixes #355.	2026-07-14 19:00:01 +00:00
timothyandOpenAI Codex	b37924545c	chore(ci): retry flaky Libraries screen test ... Retrigger CI after the existing Libraries scan-progress test failed once remotely but passed six consecutive local runs at the same documentation-only PR head. Refs #355 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 20:51:59 +02:00
timothyandOpenAI Codex	a54a2b6f82	chore(ci): retry runner setup for docs PR ... Retrigger CI after the migration job failed in Setup .NET while cleaning a missing runner-cache file, before any migration command executed. Refs #355 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 20:46:01 +02:00
timothyandOpenAI Codex	67bfc1ceb1	docs(queue): record cheap-worker launch config ... Record the tested GPT-5.4-Mini low-effort worker command, current spawn-agent limitation, and unsupported legacy model trap so future sessions can route bounded work without rediscovery. Refs #355 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 20:33:21 +02:00
timothyandOpenAI Codex	1e0eaca35e	docs(queue): start tool-bearing selectors at low effort ... Clarify that enabled web_search makes a cheap worker tool-bearing even when the selector intends to use only Gitea, reserve minimal for tool-free supplied-evidence synthesis, and require hard evidence/output caps. Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 20:03:57 +02:00
timothyandOpenAI Codex	7cbd871ab7	test(spa): close remaining playout gate gaps ... Cover the None action matrix, required add inputs, file-edit blank/trim/payload/refresh/error behavior, and clearing a default deco to null. Refs #245 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 19:22:41 +02:00
timothyandOpenAI Codex	6b41350e0c	test(spa): complete playout kind coverage ... Exercise default-deco persistence and errors plus the complete action, add-dialog, and edit-field kind matrices identified by cold review. Refs #245 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 19:12:56 +02:00
timothyandOpenAI Codex	533abe7cdb	refactor(spa): extract playouts screen ... Move the Playouts UI, route wrapper, helpers, and detailed behavior tests into a colocated screen module while preserving App-level navigation coverage. Refs #245 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 18:54:32 +02:00
timothy	e454ed94fd	Merge pull request 'docs(queue): enforce milestone-aware picker ranking' (#348) from codex/queue-picker-claim-comments into main	2026-07-14 06:03:46 +00:00
timothy	ffb3e6d5e1	Merge pull request 'fix(spa): clear dirty guard before saved navigation' (#349) from codex/344-dirty-guard into main	2026-07-14 06:02:35 +00:00
timothyandOpenAI Codex	b9305fdee9	fix(spa): preserve remote drafts during save ... Disable and gate remote connection draft inputs while a save owns the current revision. Exercise the real App-owned route transition after a successful save so the regression proves the editor unmounts without a dirty prompt. Refs #344 Co-Authored-By: OpenAI Codex <codex@openai.com>	2026-07-14 00:06:29 +02:00