Redirect matcher is exact-match only: parameterized legacy routes will hard-404 after Blazor deletion (Step 1 infeasible as written) #204
Closed
opened 2026-07-09 21:21:34 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Blazor removal (#91 phase b)
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#204
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: MUST-FIX (correctness gap in the removal plan — ersatztv#91 phase (b) Step 1)
What's wrong
LegacyUiRedirects.csmatches exact paths only —Map.TryGetValue(value, ...)against a static dictionary, with an explicit comment "EXACT paths only (no prefix matching)". Its 13 current entries are all parameterless.The plan's Step 1 says: "add every SPA-READY route to
LegacyUiRedirects.cs(including id-carrying detail/editor routes → their/app/...equivalents)." This is not expressible in the current mechanism. Routes like/media/movies/{MovieId:int},/media/tv/shows/{ShowId:int},/channels/{Id:int},/blocks/{Id:int},/playouts/block/{Id:int},/media/collections/{Id:int}, etc. cannot be enumerated as static keys.Blast radius
After Step 2 deletes Blazor, every parameterized legacy URL that Step 1 could not redirect returns a hard 404 (Blazor is gone; there's no fallback and no wildcard redirect). That breaks:
/media/...//channels/{id}scheme,This directly violates the "nothing of value dies" mandate for deep links.
Required before gate clears
Either:
/media/movies/{id}→/app/media/movies/{id}), then Step 1 becomes feasible; orThe plan currently promises (1) via a mechanism that only supports exact matches — that contradiction must be resolved before deletion.
[PLAN-MODE]— touches the redirect middleware design.Verified —
LegacyUiRedirects.TryGetRedirectis a pure exact-match dictionary lookup, so the plan's "add every SPA-READY route incl. id-carrying ones" was infeasible as written.Proposed resolution (to land in the removal PR, Step 1):
/media/movies/{id}→/app/media/movies/{id},/channels/{id}→/app/edit-channel/{id},/blocks/{id}→/app/blocks/{id},/media/tv/shows/{id}→/app/media/shows/{id}, etc. Routes whose Blazor detail pages merged into a list screen (e.g./playouts/classic/{id}) redirect to the list (/app/playouts) — deep state is dropped deliberately, not 404'd./app— this replacesMapFallbackToPage("/_Host")so nothing hard-404s post-deletion.Will implement with the removal PR; leaving open until then.
timothy referenced this issue2026-07-11 01:14:09 +02:00
claiming — session started 2026-07-11 (evening). Scope this session: extend
LegacyUiRedirectsto express id-carrying pattern rules and populate the SPA-ready ones (completes phase-(a) Step 1 for parameterized routes), gated perblazor-route-parity.mdverdicts. The catch-all fallback that replacesMapFallbackToPage("/_Host")stays coupled to the removal PR (arc item 4) since Blazor still serves un-migrated routes.[PLAN-MODE]design pass escalated to Fable before implementing.Closed via PR #260 (merged to main
495e450e, fast-forward)What was done: Extended
LegacyUiRedirectsfrom an exact-match dictionary to a two-tier matcher (signature unchanged), making the removal plan's Step 1 — "add every SPA-READY route incl. id-carrying detail/editor routes" — expressible for the first time.Map, now 52 entries (13 foundational + #204 (A)/(B) parameterless routes + (E-base) browse roots whose targets carry?kind=…).PatternRulesegment templates ((C) id-substituting, (C2) mid-path id, (D) id-dropping detail→list, (E-page)/…/page/{n}→?kind=), first-match-wins, consulted only on a Tier-1 miss.{id}= strict positive integer (NumberStyles.None,> 0) → non-int/0/neg/overflow falls through to Blazor (never a broken/app/edit-channel/abc). This strictness is also what makes the rule set collision-free by construction.AppendQueryStringhelper&-merges the incoming query into?kind=targets — fixes the malformed double-?(/media/movies?page=2→/app/media?kind=movies&page=2); plain targets keep byte-identical behavior. One-lineStartup.cschange; redirect stays GET/HEAD-only 302 beforeUseRouting()./api|/artwork|/docs|/openapi|/iptv|/app|/media/sources— the matcher's specificity is load-bearing protection for those un-prefix-guarded surfaces.Design: resolved via a
[PLAN-MODE]design pass (mechanism, query-collision, id-validation, rule ordering) — recorded indocs/decisions.md(2026-07-11, #204).Files changed:
ErsatzTV/LegacyUiRedirects.cs,ErsatzTV/Startup.cs(one line),ErsatzTV.Tests/LegacyUiRedirectsTests.cs,docs/blazor-route-parity.md(§2 rows → §1),docs/decisions.md.Verification:
dotnet build0 errors; 1132 tests green; live E2E 14/14 curl probes on the running host (7 correct 302→/appincl. the double-?fix verified live, HEAD-like-GET, all 302-not-301, correct fall-throughs for/channels/abc,/media/sources/plex,/system/health,/api/*); fork adversarial review = MERGEABLE (its one nit — Tier-2 not covered by the guard meta-test — fixed in follow-up495e450e).Deferred (deliberate, documented): the catch-all fallback replacing
MapFallbackToPage("/_Host")stays with the removal PR (#91 phase b, arc item 4) — it can't land while Blazor still serves un-migrated routes./media/sources/*(#202) and/system/health(escape hatch) remain un-redirected by design, encoded as negative tests. Two non-blocking review notes (double-trailing-slash on an id route falls through, matching existing//-hardening posture;/media/collections/{id}drops the id per the ratified in-screen-editor parity verdict) need no change.Docs updated (same PR):
docs/blazor-route-parity.md,docs/decisions.md.Net effect: the #91b removal PR is de-risked — every PARITY-OK route now redirects; the removal PR only has to flip the deletion switch + add the catch-all fallback.