#91b — remove legacy Blazor Server UI #274

Merged

timothy merged 4 commits from feat/91b-blazor-removal into main 2026-07-11 21:30:15 +02:00

Conversation 0 Commits 4 Files Changed 220

+294 -34266

timothy commented 2026-07-11 21:01:36 +02:00

Owner

Copy Link

Copy Source

Milestone-capping removal of the legacy Blazor Server / MudBlazor UI (#91 phase b). Every route it served now has SPA parity, so it is deleted. Follows docs/blazor-route-parity.md §5 (the removal runbook) and the auth-posture sign-off in docs/decisions.md (#206).

What changed

• Deleted (206 files): ErsatzTV/Pages/**, Shared/**, ViewModels/** (39 edit VMs), Validators/** (10 edit-VM validators), App.razor, _Imports.razor, Locals/{Shared,Pages}/** (Blazor loc resx — Locals/Resources.* kept), wwwroot/css + wwwroot/lib, libman.json, and the orphaned MultiSelectBaseTests.cs.
• Startup.cs (surgical): removed AddRazorPages/AuthorizeFolder("/"), AddServerSideBlazor, AddMudServices, AddSortable, AddCourier, the IHtmlSanitizer registration, the Blazor-attached OIDC UseAuthentication/UseAuthorization middleware (per #206), MapBlazorHub, and MapFallbackToPage("/_Host"). Renamed the branch blazor→legacy; it still co-hosts MapControllers(), /docs (Scalar), dev MapOpenApi() and the redirect middleware. Replaced the _Host fallback with a catch-all MapFallback → 302 /app, excluding /api|/artwork|/docs|/openapi (genuine 404) per #204.
  • Kept (must-not-break, per #206): OIDC/JWT/API-key service wiring (inert unless configured; real auth is #197), ConditionalIptvAuthorizeFilter (/iptv/*), ApiKeyAuthorizationFilter (mutating /api/*).
• Pruned 9 now-unused packages (each verified zero remaining consumers) from Directory.Packages.props + ErsatzTV.csproj: MudBlazor, Heron.MudCalendar, Blazored.FluentValidation, BlazorSortable, MediatR.Courier.DependencyInjection, Markdig, HtmlSanitizer, Chronic.Core, NaturalSort.Extension. Also removed the now-dead #25 razor-Sonar NoWarn.
• LegacyUiRedirects.cs: added the 14 /media/sources/* → /app/libraries/* redirects (SPA screens landed in #202) and lifted the #204-era /media/sources prefix ban.

Verification

• dotnet build -c Release clean (0 errors; only the pre-existing NU1903 Microsoft.OpenApi advisory warning).
• Full dotnet test ErsatzTV.sln green: ErsatzTV.Tests 1350, Core 493, Scanner 1467, Infrastructure 53, Architecture 5, FFmpeg 20 — 0 failed.
• Updated Startup source-text tests + new regression tests: Blazor wiring is gone, the catch-all is wired, all 14 media-sources routes redirect.
• No /api endpoint change → no OpenAPI regen; no web/ change.

Rollback

Tag blazor-final is cut on the pre-merge main commit as the first merge action (docs/decisions.md #205); restore = git checkout blazor-final (test image) or git revert this single merge commit.

Docs (same PR)

blazor-route-parity.md (phase b COMPLETE), decisions.md (removal entry), CLAUDE.md, contributing.md, README.md.

Gates before merge

Mandatory cold adversarial pass (in progress) + live-E2E redirect sweep + Fable go/no-go, then merge consent.

Part of #91.

🤖 Generated with Claude Code

Milestone-capping removal of the legacy Blazor Server / MudBlazor UI (#91 phase b). Every route it served now has SPA parity, so it is deleted. Follows `docs/blazor-route-parity.md §5` (the removal runbook) and the auth-posture sign-off in `docs/decisions.md` (#206). ## What changed - **Deleted** (206 files): `ErsatzTV/Pages/**`, `Shared/**`, `ViewModels/**` (39 edit VMs), `Validators/**` (10 edit-VM validators), `App.razor`, `_Imports.razor`, `Locals/{Shared,Pages}/**` (Blazor loc resx — `Locals/Resources.*` kept), `wwwroot/css` + `wwwroot/lib`, `libman.json`, and the orphaned `MultiSelectBaseTests.cs`. - **`Startup.cs`** (surgical): removed `AddRazorPages`/`AuthorizeFolder("/")`, `AddServerSideBlazor`, `AddMudServices`, `AddSortable`, `AddCourier`, the `IHtmlSanitizer` registration, the Blazor-attached OIDC `UseAuthentication/UseAuthorization` middleware (per #206), `MapBlazorHub`, and `MapFallbackToPage("/_Host")`. Renamed the branch `blazor`→`legacy`; it still co-hosts `MapControllers()`, `/docs` (Scalar), dev `MapOpenApi()` and the redirect middleware. Replaced the `_Host` fallback with a **catch-all** `MapFallback` → 302 `/app`, excluding `/api|/artwork|/docs|/openapi` (genuine 404) per #204. - **Kept** (must-not-break, per #206): OIDC/JWT/API-key **service** wiring (inert unless configured; real auth is #197), `ConditionalIptvAuthorizeFilter` (`/iptv/*`), `ApiKeyAuthorizationFilter` (mutating `/api/*`). - **Pruned 9 now-unused packages** (each verified zero remaining consumers) from `Directory.Packages.props` + `ErsatzTV.csproj`: MudBlazor, Heron.MudCalendar, Blazored.FluentValidation, BlazorSortable, MediatR.Courier.DependencyInjection, Markdig, HtmlSanitizer, Chronic.Core, NaturalSort.Extension. Also removed the now-dead #25 razor-Sonar `NoWarn`. - **`LegacyUiRedirects.cs`**: added the 14 `/media/sources/*` → `/app/libraries/*` redirects (SPA screens landed in #202) and lifted the #204-era `/media/sources` prefix ban. ## Verification - `dotnet build -c Release` clean (0 errors; only the pre-existing NU1903 Microsoft.OpenApi advisory warning). - Full `dotnet test ErsatzTV.sln` green: ErsatzTV.Tests 1350, Core 493, Scanner 1467, Infrastructure 53, Architecture 5, FFmpeg 20 — 0 failed. - Updated Startup source-text tests + new regression tests: Blazor wiring is gone, the catch-all is wired, all 14 media-sources routes redirect. - No `/api` endpoint change → no OpenAPI regen; no `web/` change. ## Rollback Tag `blazor-final` is cut on the pre-merge `main` commit as the first merge action (`docs/decisions.md` #205); restore = `git checkout blazor-final` (test image) or `git revert` this single merge commit. ## Docs (same PR) `blazor-route-parity.md` (phase b COMPLETE), `decisions.md` (removal entry), `CLAUDE.md`, `contributing.md`, `README.md`. ## Gates before merge Mandatory cold adversarial pass (in progress) + live-E2E redirect sweep + Fable go/no-go, then merge consent. Part of #91. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

timothy added 1 commit 2026-07-11 21:01:36 +02:00

feat(91b): remove legacy Blazor Server UI (#91 phase b) ... 408b0deb89

The ChicoryTV React SPA (web/, served at /app) now has full parity for every
route the Blazor UI served, so the legacy Blazor Server / MudBlazor UI is
deleted. This is the milestone-capping removal of #91 phase (b).

Deleted: ErsatzTV/Pages/**, Shared/**, ViewModels/** (39 edit VMs),
Validators/** (10 edit-VM validators), App.razor, _Imports.razor,
Locals/{Shared,Pages}/** (Blazor loc resx; Locals/Resources.* kept),
wwwroot/css + wwwroot/lib, libman.json, and the orphaned MultiSelectBaseTests.

Startup.cs (surgical, not wholesale): removed AddRazorPages/AuthorizeFolder,
AddServerSideBlazor, AddMudServices, AddSortable, AddCourier, the HtmlSanitizer
registration, the Blazor-attached OIDC UseAuthentication/UseAuthorization
middleware (per the #206 auth-posture sign-off), MapBlazorHub, and
MapFallbackToPage("/_Host"). Renamed the branch blazor->legacy; it still
co-hosts MapControllers, /docs (Scalar), dev MapOpenApi and the redirect
middleware. Replaced the _Host fallback with a catch-all (MapFallback ->
302 /app) that excludes /api|/artwork|/docs|/openapi (genuine 404) per #204.
Kept all OIDC/JWT/API-key service wiring (inert unless configured; real auth
is #197), ConditionalIptvAuthorizeFilter, ApiKeyAuthorizationFilter.

Pruned 9 now-unused packages (all verified zero remaining consumers) from
Directory.Packages.props + ErsatzTV.csproj: MudBlazor, Heron.MudCalendar,
Blazored.FluentValidation, BlazorSortable, MediatR.Courier.DependencyInjection,
Markdig, HtmlSanitizer, Chronic.Core, NaturalSort.Extension. Also removed the
now-dead #25 razor-Sonar NoWarn.

LegacyUiRedirects: added the 14 /media/sources/* -> /app/libraries/* redirects
(SPA screens landed in #202) and lifted the #204-era /media/sources prefix ban.

Tests: Release build clean; full solution suite green. Updated Startup
source-text tests + added regression coverage that Blazor wiring is gone, the
catch-all is wired, and all 14 media-sources routes redirect.

Docs: blazor-route-parity.md (phase b COMPLETE), decisions.md (removal entry),
CLAUDE.md, contributing.md, README.md all updated in this PR.

Rollback: tag blazor-final is cut on pre-merge main as the first merge action.

Part of #91.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

timothy added 1 commit 2026-07-11 21:09:29 +02:00

fix(91b): delete orphaned Blazor NavigationManagerExtensions ... 4407dd53af

Cold-review Low-1: ErsatzTV/Extensions/NavigationManagerExtensions.cs survived
the removal — the last non-deleted .cs still importing
Microsoft.AspNetCore.Components/JSInterop and calling the deleted
blazorHelpers.scrollToFragment JS. Fully unreferenced (compiled only via the
shared framework). Removing it completes the Blazor deletion.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

timothy added 1 commit 2026-07-11 21:10:18 +02:00

chore(91b): clean up dead Blazor residue (Serilog override + stale comment) ... 3c5d05908a

Codex-review nits: drop the now-inert "MudBlazor" Serilog level override in
appsettings.json (package removed) and reword the PlaylistController comment
that referenced the deleted Blazor MultiSelectBase.AddItemsToPlaylist path. No
behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

timothy added 1 commit 2026-07-11 21:19:47 +02:00

Merge remote-tracking branch 'origin/main' into feat/91b-blazor-removal 78262ea4cb

timothy referenced this pull request 2026-07-11 21:29:22 +02:00

Replace-all reconcile: content-aware stable child identity (moved item inherits the wrong slot's state) — split from #253 #259

timothy merged commit 78262ea4cb into main 2026-07-11 21:30:15 +02:00

timothy deleted branch feat/91b-blazor-removal 2026-07-11 21:30:15 +02:00

timothy referenced this pull request 2026-07-11 21:31:17 +02:00

ChicoryTV SPA: Blazor → SPA cutover (retire old UI) #91

timothy referenced this pull request 2026-07-11 21:32:05 +02:00

ChicoryTV rewrite — queue tracker (goal, arc, session protocol) #237

timothy referenced this pull request 2026-07-11 22:13:09 +02:00

ChicoryTV rewrite — queue tracker (goal, arc, session protocol) #237

timothy referenced this pull request 2026-07-11 22:39:55 +02:00

chore(release): ship v26.7.0 (Blazor removal) to prod + revert deploy model to :prod-following #278

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

ad-hoc

One-off / ad-hoc work not tracked by a dedicated issue

api

REST API / HTTP endpoints

bug

Something isn't working

ci-cd

Build, test, deploy pipeline

content

Channel content / schedules / playlists

dependencies

Dependency updates (Renovate)

enhancement

New feature or improvement

frontend

ChicoryTV React SPA frontend

in-progress

Claimed by an active session — do not pick up

jellyfin

Jellyfin tuner / IPTV integration

parked

Excluded from automatic queue pickup; work only when explicitly selected

priority: high

priority: low

priority: medium

review

Adversarial review finding

security

Security / vulnerability fix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

renovate timothy (Timothy)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: timothy/ersatztv#274