Rollback: cut and document a dedicated pre-removal Blazor tag before deletion #205

Closed
opened 2026-07-09 21:21:46 +02:00 by timothy · 3 comments
Owner

Severity: SHOULD-FIX (doesn't block deletion, but is the plan's own stated safety net)

What's wrong

The gate comment asks: "can we restore Blazor from a tag if a gap surfaces post-deletion?" The only tags in the repo are release tags (v26.6.0, v26.5.0, …). There is no dedicated pre-removal tag at the exact commit that still has Blazor, and Step 2/3 of the plan doesn't cut one.

Since deletion removes both the reference implementation and the /system/health escape hatch (Index.razor is deleted), a post-deletion gap is expensive to recover from — you'd have to guess which release tag still matches current main minus Blazor and cherry-pick the difference.

Required (recommended)

As the first action of the Step 2 deletion PR, cut an annotated tag (e.g. blazor-final / pre-spa-cutover) on the pre-deletion commit and document the restore procedure (checkout tag → cherry-pick the deleted Pages//Shared//startup wiring, or revert the deletion commit) in the phase-(b) notes. Cheap insurance; makes rollback a one-liner instead of an archaeology exercise.

**Severity: SHOULD-FIX** (doesn't block deletion, but is the plan's own stated safety net) ## What's wrong The gate comment asks: *"can we restore Blazor from a tag if a gap surfaces post-deletion?"* The only tags in the repo are release tags (`v26.6.0`, `v26.5.0`, …). There is **no** dedicated pre-removal tag at the exact commit that still has Blazor, and Step 2/3 of the plan doesn't cut one. Since deletion removes both the reference implementation *and* the `/system/health` escape hatch (`Index.razor` is deleted), a post-deletion gap is expensive to recover from — you'd have to guess which release tag still matches current `main` minus Blazor and cherry-pick the difference. ## Required (recommended) As the first action of the Step 2 deletion PR, cut an annotated tag (e.g. `blazor-final` / `pre-spa-cutover`) on the pre-deletion commit and document the restore procedure (checkout tag → cherry-pick the deleted `Pages/`/`Shared/`/startup wiring, or revert the deletion commit) in the phase-(b) notes. Cheap insurance; makes rollback a one-liner instead of an archaeology exercise.
timothy added the priority: mediumreview labels 2026-07-09 21:21:46 +02:00
Author
Owner

Accepted. Plan: cut an annotated blazor-final tag on the main commit immediately preceding the removal merge (not now — main will move before the removal PR), and document the restore path in the removal PR (checkout tag → docker build → pin test container). Will execute as part of the removal PR merge routine.

Accepted. Plan: cut an annotated `blazor-final` tag on the main commit immediately preceding the removal merge (not now — main will move before the removal PR), and document the restore path in the removal PR (checkout tag → `docker build` → pin test container). Will execute as part of the removal PR merge routine.
timothy added this to the Blazor removal (#91 phase b) milestone 2026-07-11 01:14:30 +02:00
timothy added the in-progress label 2026-07-11 16:40:13 +02:00
Author
Owner

Claiming — session started 2026-07-11 (evening), paired with #206. Deliverable this session: document the pre-removal rollback-tag procedure (tag name, exact git tag -a step to run as the first action of the removal merge — not now, since main will move before the removal PR — plus the restore path) in docs/decisions.md + the removal runbook, so the removal PR routine just executes it. No tag cut this session. Docs-only, parallel-safe vs #202/#204/#253.

Claiming — session started 2026-07-11 (evening), paired with #206. Deliverable this session: document the pre-removal rollback-tag procedure (tag name, exact `git tag -a` step to run as the first action of the removal merge — **not now**, since main will move before the removal PR — plus the restore path) in `docs/decisions.md` + the removal runbook, so the removal PR routine just executes it. No tag cut this session. Docs-only, parallel-safe vs #202/#204/#253.
Author
Owner

Resolved — rollback-tag procedure documented (PR #261, merged 7608ccce)

What was done. Documented the pre-removal blazor-final rollback-tag procedure + restore path in docs/decisions.md, and made it step 1 of the new removal runbook (docs/blazor-route-parity.md §5), so the removal PR routine executes it deterministically.

Procedure (recorded):

  1. As the first action of the Step-2 deletion PR merge — on the main commit immediately preceding the removal (the last commit that still contains ErsatzTV/Pages/**) — cut git tag -a blazor-final and push it. The tag name is blazor-final (not v*), so it does not trigger the v* prod-release build in .gitea/workflows/docker-build.yml (independently verified against the workflow's tags: ['v*'] filter + startsWith(github.ref, 'refs/tags/v') publish guards).
  2. Restore path: git checkout blazor-final → docker build -f docker/Dockerfile -t ersatztv:blazor-final . → pin the test container to that image while the gap is fixed forward on main; or git revert the single deletion merge commit.

Why not cut the tag now. As agreed in the earlier comment: main still carries Blazor and will advance before the removal PR, so the tag must be cut at removal time on the exact pre-deletion commit — not now. The runbook + decisions.md entry ensure it isn't forgotten.

Docs updated (same PR): docs/decisions.md (rollback-tag entry), docs/blazor-route-parity.md (§5 runbook step 1).

Closing: the finding (plan had no documented rollback tag/restore) is resolved. The actual tag-cut is a scripted step of the gated removal PR.

## Resolved — rollback-tag procedure documented (PR #261, merged `7608ccce`) **What was done.** Documented the pre-removal `blazor-final` rollback-tag procedure + restore path in `docs/decisions.md`, and made it **step 1** of the new removal runbook (`docs/blazor-route-parity.md` §5), so the removal PR routine executes it deterministically. **Procedure (recorded):** 1. As the **first action** of the Step-2 deletion PR merge — on the `main` commit immediately preceding the removal (the last commit that still contains `ErsatzTV/Pages/**`) — cut `git tag -a blazor-final` and push it. The tag name is **`blazor-final`** (not `v*`), so it does **not** trigger the `v*` prod-release build in `.gitea/workflows/docker-build.yml` (independently verified against the workflow's `tags: ['v*']` filter + `startsWith(github.ref, 'refs/tags/v')` publish guards). 2. **Restore path:** `git checkout blazor-final` → `docker build -f docker/Dockerfile -t ersatztv:blazor-final .` → pin the **test** container to that image while the gap is fixed forward on `main`; or `git revert` the single deletion merge commit. **Why not cut the tag now.** As agreed in the earlier comment: `main` still carries Blazor and will advance before the removal PR, so the tag must be cut at removal time on the exact pre-deletion commit — not now. The runbook + decisions.md entry ensure it isn't forgotten. **Docs updated (same PR):** `docs/decisions.md` (rollback-tag entry), `docs/blazor-route-parity.md` (§5 runbook step 1). Closing: the finding (plan had no documented rollback tag/restore) is resolved. The actual tag-cut is a scripted step of the gated removal PR.
timothy removed the in-progress label 2026-07-11 17:21:29 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#205