Removal plan has no auth step: deleting the last challenged Blazor page leaves only the open SPA #206
Closed
opened 2026-07-09 21:21:54 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Blazor removal (#91 phase b)
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#206
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: SHOULD-FIX (confirm-before-deletion, not necessarily a build blocker)
What's wrong
Phase (a)'s own merge comment flagged: "OIDC installs now land on the open SPA instead of a challenged Blazor page … SPA auth is a phase-(b) design item." The phase-(b) removal plan (Steps 1–3) contains no auth step — it deletes
Index.razor(/system/health, the last Blazor-served page that could sit behind a challenge) without addressing SPA authentication.If any deployment relied on the Blazor page's auth challenge as a gate, deleting it removes that surface while the plan silently assumes "auth is handled elsewhere." GET APIs and
/appwere already unauthenticated in phase (a), so this may be no new exposure — but the removal plan should not clear the gate on an unstated assumption.Required (recommended)
Before Step 2, explicitly confirm the auth posture: enumerate what (if anything) was still behind a Blazor auth challenge, confirm the SPA + API access-control model covers it, and either add an auth step to the plan or record an explicit "no auth regression — GET APIs/SPA already open, verified" sign-off. Don't let the gate clear by omission.
Accepted. Known since phase (a) (#91 comment, PR #148 review): OIDC-challenged Blazor pages stopped being the landing surface when
/flipped to the open SPA — GET APIs and/appwere already unauthenticated, so removal changes exposure only by deleting the last[Authorize]-reachable pages. Removal PR will: (1) verify no auth-gated user-facing capability is lost (enumerate[Authorize]/OIDC-conditional wiring in Startup + Pages), (2) record the resulting posture in docs/decisions.md. Real SPA/API auth design is deliberately deferred to #197 (API security review, already queued as a hard gate before any remote exposure).timothy referenced this issue2026-07-11 01:14:09 +02:00
Claiming — session started 2026-07-11 (evening). Producing the auth-posture sign-off the removal plan needs: enumerating the actual
[Authorize]/OIDC-conditional wiring inStartup.cs+Pages/, confirming no auth-gated capability is lost on Blazor deletion, and recording the resulting posture indocs/decisions.md(+ folding the resolved item into the removal runbook). No production code changes this session — it's the analysis/sign-off that arc item 4's removal PR will cite. Parallel-safe vs the in-flight #202/#204/#253 sessions (docs-only, append-oriented).Resolved — auth-posture sign-off recorded (PR #261, merged
7608ccce)What was done. Enumerated the actual authorization wiring in
ErsatzTV/Startup.cs+ErsatzTV/Pages(in code, not assumed) and recorded a sign-off indocs/decisions.md, plus folded it into the new removal runbook (docs/blazor-route-parity.md§5) so the gate can't clear by omission.Findings (verified in code):
OidcHelper.IsEnabled, config-gated on Authority/ClientId/ClientSecret) attaches auth viaAddRazorPages(… AuthorizeFolder("/"))+blazor.UseAuthentication/UseAuthorization(Startup.cs:379-385, 764-770).AuthorizeFolder("/")gates Razor Pages only, whose sole user-facing page isPages/_Host.cshtml(the Blazor host;Shared/_Favicons.cshtmlis a non-routable cosmetic partial). So the OIDC challenge protects exactly the Blazor UI, nothing else./app(SPA) — ownMapWhen(/app)static branch, no auth middleware (Startup.cs:701-714); open since phase (a) (PR #148)./api/*— zero[Authorize]attributes (verified acrossControllers/); noFallbackPolicy, so non-attributed endpoints are open. Only optional gate isApiKeyAuthorizationFilteron mutating endpoints — Blazor-independent./iptv/*—ConditionalIptvAuthorizeFilter(JWT), ownMapWhenbranch (Startup.cs:797-803) — Blazor-independent.Sign-off (the finding's ask). Deleting Blazor removes the OIDC challenge's only attachment point. No capability is lost (every Blazor capability already has an open SPA equivalent) and no NEW exposure is introduced beyond the phase-(a) state — the open SPA already became the default admin surface at phase (a); removal only deletes the now-redundant challenged duplicate. The independent gates (
/iptvJWT, API-key filter) survive. Real SPA/API authentication is deferred to #197 (hard gate before remote exposure).Root cause of the finding. The removal plan (Steps 1–3) listed no auth step, so the gate risked clearing on the unstated assumption "auth handled elsewhere." Now stated explicitly and recorded.
Independent review. A cold, zero-shared-context reviewer independently verified every claim (incl. all cited line numbers) against source — verdict SIGN-OFF SOUND, no counterexample capability found.
Deferred (removal PR's job, per runbook §5 step 2/3): physically deleting the Blazor-attached OIDC pieces (
AuthorizeFolder("/"),blazor.UseAuthentication/UseAuthorization) while keeping the OIDC/JWT/API-key service wiring (ripping OIDC out is a #197 call).MapControllers()+/docsco-hosted in the BlazorMapWhenbranch must survive the surgical reduction — flagged in the runbook's must-not-break list.Docs updated (same PR):
docs/decisions.md(auth-posture entry),docs/blazor-route-parity.md(§5 runbook).Closing: the finding is resolved. The physical deletion happens in the gated removal PR, which the runbook now steers.