Rerun collections: the list endpoint returns a null selection for every row, and the detail GET 500s or nulls for five media types #671
Closed
opened 2026-07-27 00:00:10 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#671
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found while working #651 (searchable library-browse pickers) and confirmed by reading the handlers. All server-side, all predating #651. The SPA side is defended in #651's branch — the editor now merges rather than replaces, so a stored id is never cleared — but that is a client-side guard over a server-side defect, and the underlying data is still missing.
1. The list endpoint returns a null selection for EVERY rerun collection
ErsatzTV.Application/MediaCollections/Queries/GetPagedRerunCollectionsHandler.cshas no.Include()calls at all and runsAsNoTracking():But
Mapper.ProjectToViewModel(RerunCollection)reads four navigations —collection.Collection,collection.MultiCollection,collection.SmartCollection,collection.MediaItem. With no eager load and no lazy loading configured, all four are null for every row, of every collection type.Effect in production: the list badge renders
Collection ·with no name, for every rerun collection. The editor is entirely dependent on the detail GET to recover the selection.2.
Mapperreturns null forRemoteStream, and 500s on two typesErsatzTV.Application/MediaCollections/Mapper.cs— thecollection.MediaItem switchenumerates Show, Season, Artist, Movie, Episode, MusicVideo, OtherVideo, Song, Image and then falls through_ => null.RemoteStreamhits the fallthrough, so a successful 200 carries a null selection.Worse, the detail handler (
GetRerunCollectionByIdHandler) loads sufficient metadata only for Show, Season, Artist and Movie. The remaining types go through unloaded navigations:_ => null)Seasonnavigation inEpisodeTitleArtistnavigationAn endpoint returning 500 for two of its supported types is the sharp end of this.
Why it wasn't caught
Both the id and the name are derived from the same eager-loaded navigation, so the id is only ever as available as the name — there is no state where the API knows which item is selected but not what it's called. That coupling is why the client-side symptom looked like a naming problem rather than a loading one.
Done-when
GetPagedRerunCollectionsHandlereager-loads the navigationsProjectToViewModelreads, so list rows carry a real selection id and nameGetRerunCollectionByIdHandlerloads sufficient metadata for every supported type — no 500 for Episode or MusicVideoMapper's_ => nullfallthrough no longer silently dropsRemoteStream(handle it, or make the unhandled case loud)ProgramScheduleItemCollectionType/ media type the entity permits, not a sample — the defect here is precisely the types nobody enumeratedContext: #651. The client-side guard that makes this survivable lives in
feat/651-searchable-pickers(RerunCollectionsScreenmerges the refresh instead of replacing it) — that guard should stay even after this is fixed.Claiming this (Claude Code orchestrator session, 2026-07-28). Four-way claim check clean: no open PR references #671,
git ls-remote --heads origin '*671*'empty, no prior comments,origin/mainfresh atd4ea1584c.Closing record
Outcome: Shipped in #692 (merged as
036bcfc5a). Both handlers now project through one sharedRerunCollectionQueryExtensions.IncludeSelectionDetails(); the media-item switch — previously duplicated verbatim forRerunCollectionandPlaylistItem— is oneProjectMediaItemToViewModelthat handlesRemoteStreamand never falls through to null; every metadata navigation inMediaItems.Mapperdegrades to"???"rather than throwing.One correction to the issue body:
RemoteStreamdoes have a mapper overload, but it returnsRemoteStreamViewModel, an unrelated record, and C# will not overload on return type — so there was no named projection to fall back on. Hence the newProjectToNamedViewModel.Root cause: The selected id and the display name are read off the same eager-loaded navigation, so the id is only ever as available as the name. The list handler had no
.Include()calls at all and ranAsNoTracking()(which suppresses navigation fixup), and the by-id handler covered 4 of 10 media types. The issue body identified this coupling correctly — and it is also why the symptom looked cosmetic (an unlabelled badge) when the real harm was the dropped id silently clearing a stored selection.Decisions/conventions changed: Added
api.selection-projection-include-chain— one shared include chain per projected aggregate (joining the#229IncludeScheduleItemDetailsprecedent, extended from the write path to the read path), and a flattening switch that never ends in_ => null.Reusable knowledge:
SongMetadata.Artistsis a nullable EF primitive collection (JSON in one column, not a navigation) thatFallbackMetadataProviderleaves unassigned for a song whose tags fail to read;string.JointhrowsArgumentNullException, notNullReferenceException. A "null navigation" audit misses it and so does a grep forNullReferenceException. It was already a live 500 onGET /api/v1/playlists/{id}/itemsbefore this branch (verified againstorigin/main) — eager-loading it on the rerun list merely made the same throw reachable on a second path.Playouts/Mapper.GetDisplayTitle, likewise live, feeding the playout guide, troubleshooting, media-item info and channel states.LibraryBrowseItemMapperalready wroteArtists ?? [], so the nullability was known in-tree — those sites were simply never swept.Episode → Season → Showstill renderss00e04 - Selected episode, placeholder-free. Pin the whole expected string.IsSupportedSelectionType) rather than hand-listing it, so a newly-supported type joins coverage automatically and trips a louddefault:.Verification: All 7 test projects green (4,444 passed, 0 failed). Every mechanism was removed in turn and the suite quoted red before restoring it — stripping the list chain failed all 13 types on "lost its selected id"; the original 4-type chain failed exactly the 6 types named here; reverting the bare dereferences reproduced
NullReferenceExceptionfor Episode/MusicVideo; reverting eitherArtistsguard reproducedArgumentNullException; reverting the chapter fix renderedErsatzTV.Core.Domain.Song (Chapter 1). CI green on2249a806c, withBuild & testat 25m35s (a real run, not the docs-only fast path). Four review rounds: one cross-family (Codex) and three cold same-family. No live-E2E: this is a read-path projection change with no write path and no API contract change.Deferred: #690 (paged
TotalCountignores the search query — pre-existing, different axis) and #691 (SongVideoGeneratordereferencesArtists/AlbumArtistsunguarded on the playback path, where the right fallback needs thought rather than a mechanical?? []).Docs updated:
docs/api-conventions.md(new §2a, "Flattening a tagged-union selection (read path)"),docs/decisions/records/api/selection-projection-include-chain.md, and the regenerateddocs/decisions/README.mdcatalog.