Search indexers mutate SongMetadata.Artists on a possibly-tracked entity (??= []) — same shape rejected in #691
#701
Closed
opened 2026-07-28 23:06:05 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#701
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by adversarial review of PR #700 (#691). Pre-existing; not introduced by that PR, which correctly left these alone rather than widening scope.
Why this is worth a separate issue
#691 originally fixed the nullable
SongMetadata.Artists/AlbumArtistsby making the entity coalesce on read. That design was rejected after a reviewer probed the realTvContext: with EF's defaultPreferFieldaccess mode, mutating the field during a read on a tracked entity flips the entity toModified, and the nextSaveChangeswrites[]over theNULLcolumn.Two places already do structurally the same thing, by assignment rather than by getter:
ErsatzTV.Infrastructure/Search/LuceneSearchIndex.cs:1321-1322ErsatzTV.Infrastructure/Search/ElasticSearchIndex.cs:766-767in
UpdateSong. If theSongMetadatareached there came from a tracked query, indexing an untagged song sets the property, marks itModified, and a laterSaveChangesin the same scope silently rewritesNULL→[]across the table.This may well be harmless today — it depends entirely on whether that path is
AsNoTrackingand whether anything saves in the same scope. That is exactly the point: it is currently unknown, and #691 established that "no test observes the column after a tracked read" means the existing suite cannot tell us. The guards themselves are also now redundant, since the read sites they were protecting are guarded at the point of use as of #691.Second, smaller item
ErsatzTV.Application/Channels/Commands/RefreshChannelDataHandler.cs:610-611assigns the raw nullable lists into the Scriban template context:The assignment cannot throw, and the shipped
_song.sbntxtonly doesarray.join, so current output is unaffected. But a user's custom_song.sbntxtdoing anything else with a null collection could fault on untagged songs. Worth guarding for consistency with the #691 sweep.Done-when
UpdateSongpath holds a trackedSongMetadata(probe it; do not reason about it — reasoning is what got #691's first design wrong)??=guards are now dead given #691's read-site guards, and remove them if so rather than leaving three contradictory stories about the same fieldRefreshChannelDataHandlertemplate fieldsRelated
#691 (read-site guards), #671 /
api.selection-projection-include-chain(the sweep-by-FIELD convention).Box 3 — the issue's premise was wrong, recording it rather than ticking past it. This box assumed
the two
??=guards were "now redundant given #691's read-site guards". They were not: they were theonly thing protecting the four reads below them, and deleting them alone throws on every untagged song
(measured —
NullReferenceExceptionat the Luceneforeach; the Elastic.ToList()reads throwArgumentNullException). So they were not removed as dead; they were REPLACED by read-site guards thatmove with their reads. Ticked as decided-and-acted-on, not as premise-confirmed.
Box 1 — the empirical answer is "not tracked today". Both feeds are
AsNoTracking(
SearchRepository.GetItemToIndex,GetAllSongs), so no shipped caller loses data. The mutation wasremoved regardless and the indexer's own contract pinned by test, because "today's two callers" is not
a property of the indexer — which is exactly what #691 recorded as a loaded gun.
Claiming this (Claude Code session, 2026-08-22). Pre-claim checks per
process.parallel-session-claim: no open PR referencing #701 (only three Renovate PRs open),git ls-remote --heads origin '*701*'empty, no prior comments on the issue, freshgit fetch origin main.Closing record
Outcome: Shipped — PR #826, merged as
7966e0816. Both search indexers andRefreshChannelDataHandlerno longer mutateSongMetadata.Artists/AlbumArtists; each site's reads moved toOptional(...).Flatten()locals with it. New fixtureSongIndexerMetadataMutationTestspins the indexer's contract. New decision recordmedia.nullable-primitive-collection-mutation.Root cause: The
??= []idiom is correct on navigation collections and appears 92 times across the app projects, so writing it two lines belowmetadata.Genres ??= []looked right. The difference is invisible at the call site and lives in the model:Artistsholds the whole list in ONE COLUMN, so the property IS the column value, and assigning it on a tracked entity flips the entry toModified.Decisions/conventions changed: Added
media.nullable-primitive-collection-mutation. It complementsapi.selection-projection-include-chain(#671), which records the read-site guard; this one covers the write half — never assign the guard back onto the entity — and derives the collection-column population from the model configuration.Reusable knowledge:
??=guards were not redundant given #691's read-site guards — they were the only thing protecting the four reads below them. Deleting them alone throws on every untagged song. Removal only works paired with a read-site guard.foreachover a null collection throwsNullReferenceException;string.Join/Enumerable.ToListon a null source throwArgumentNullException. This PR contains two of each (Luceneforeach, Elastic.ToList()), so no single exception-name grep characterises the class — which is the real reason a sweep must follow the FIELD. A clause asserting the ANE half only was inherited verbatim from #671, where it is correct, and was false here for the primary sites until measured.IList<string>underErsatzTV.Core/Domainmisses the six value-converted collections (ProgramScheduleAlternate/PlayoutTemplate×DaysOfMonth,MonthsOfYear,DaysOfWeek), which are declared as plainICollection<T>and become single columns only inData/Configurations, and misses enum collections entirely. Authoritative source is the model configuration. Storage also differs — comma-separated text for the int converter, JSON for the enum one — so "JSON array" is wrong as a class-wide description.writer.NumDocs.ShouldBe(1)was added; verified both ways.Verification:
ErsatzTV.Tests2006 passed / 4 pre-existing skips ·Core.Tests685 / 1 skip ·Infrastructure.Tests114 ·Architecture.Tests7 ·Scanner.Tests1504 — 0 failures.scripts/tests874 passed / 2 skipped. Format gate + BOM clean on all four touched.cs. CI green onb5dee2620,Build & test (.NET)524s (a real run, not the docs-only fast path). Mutation proof witnessed: restoring only the??= []clause from the real predecessor file reddens the fixture; a probe variant reportsSTATE=Modifiedand the raw column movingNULL→"[]". Two independent cold reviews (Codex GPT-5.6 cross-family; Claude Opus 5high, worktree-isolated) — C# cleared by both in round 1; four subsequent rounds were all evidence defects.Deferred:
??=exists on any of them, and the only constructors of those commands today are the two API request records, which normalize with?? [].ElasticSearchIndex.UpdateSonghas no regression test (needs a stubbed transport). Its change here is by inspection against the Lucene one. A source-text guard was considered and rejected as brittle.Docs updated:
docs/decisions/records/media/nullable-primitive-collection-mutation.md(new) +docs/decisions/README.md(regenerated). No route or/api/*change, soblazor-route-parity.md/api-conventions.md/endpoint-index.mdare not affected.