probe(756): DO NOT MERGE — does a failing continue-on-error step skip the if:-less guard? #766
Closed
timothy
wants to merge 3 commits from
probe756/coe-invariant into main
pull from: probe756/coe-invariant
merge into: :main
:main
:renovate/dotnet-monorepo
:renovate/meziantou.analyzer-3.x
:renovate/lucene.net
:renovate/sqlitepclraw.bundle_e_sqlite3-3.x
:renovate/cliwrap-3.x
:913-scripted-playout-401
:release/v26.15.0-notes
:issue-806-guard-populations
:scratch/767b-poisoned
:scratch/767b-control
:release/v26.14.0-notes
:release/v26.14.0
:docs/510-skill-logo-bug-policy
:fix/510-watermark-resolution-policy
:fix/629-verdict-classifier-falseopens
:fix/609-decisions-edit-token-scope
:issue-135-clear-to-none
:release/v26.12.0-notes
:fix/409b-lastscan-api-parity
:fix/401-updatechannel-mirror-422
:fix/327-playlist-rename-validation
:fix/410-scancancel-log-level
:fix/409-447-librariesscreen-neverscanned
:fix/338-zap-exit-code
:fix/367-plex-budget-message
:fix/310-debom-legacy-cs
:ci/604-lane-rebalance
:feat/388-design-mirror
:feat/247-test-ownership
:feat/247-primary-action
:feat/357-player-owned-playback
:feat/357-jellyfin-plugin-poc
:fix/289-mcp-hardening
:issue58-mcp
:feat/244-channels-extract
:ci/auto-bump-prod-compose
:feat/multi-rerun-collections-api
:feat/collections-api
:feat/quick-wins
:feat/185-docs-part2
:feat/140-collections-screen
:feat/146-channel-edit
:feat/147-classic-ui-link
:issue22-renovate-dashboard
:feat/91-cutover
:feat/63-composite-create
:feat/65-library-browse
:feat/85-epg
:feat/86-schedule-editor
:feat/109-dashboard-data
:feat/99-session-tracking
:fix/dockerfile-node-tag
:feat/59-spa-foundation
:docs/59-ui-redesign-brief
:feat/102-json-guide
:feat/111-schedule-durations
:feat/104-artwork-upload
:feat/103-media-sources-api
:feat/playouts-read-api
:feat/108-health-api
:feat/105-picker-list-endpoints
:issue-97-channel-state-api
:issue42-jellyfin-musicvideos
:issue46-rest-api-error-contract
:dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
:qsv-improvements
:hdr-vulkan-cuda-test
3
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
1d34a73ff0 |
probe(756): DO NOT MERGE - does a failing continue-on-error step skip the if:-less guard?
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 16s
PR Gates / Docs update reminder (pull_request) Successful in 18s
PR Gates / decisions lifecycle (pull_request) Failing after 17s
review-verdict/h10 Awaiting review verdict for 1d34a73
Review verdict / Set review-verdict status (pull_request_target) Successful in 8s
PR Gates / Script tests (pytest) (pull_request) Successful in 2m7s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 9m29s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m51s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 6m36s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 10s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 8s
|
||
|
|
7e769c1b1f |
docs(756): record the per-step marker contract and its build-lane measurement
Adds ci.required-job-step-execution-markers, updates ci.workflow-run-body-no-expressions (whose rule: named #756 as the open residual and whose scope paragraph was tracking REQUIRED contexts rather than one file), and documents the guard in docs/ci-cd.md. Decisions-Edit: yes Refs #756 |
||
|
|
2c6b0a39de |
fix(756): per-step execution markers on docker-build.yml's two REQUIRED jobs
A run: body the runner declines to interpolate is DROPPED and the job still concludes success (#751). In review-verdict.yml that is fail-CLOSED; in docker-build.yml's `test` and `migrations` — the other two required contexts on main — it is fail-OPEN: the required check goes green having done no work. Every consequential run: step now records that it began, and a trailing guard fails the job when the expected set is incomplete. Per STEP, not per job as proposed: a job-start marker only proves step 1 ran, and the dangerous drop is `Test` or the migration replay. Refs #756 |