fix(880): an absent recurrence array means unrestricted, an explicit [] is rejected #892
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#892
Reference in New Issue
Block a user
Fixes the write-side half of the absent-collection asymmetry recorded as residual (3) of
media.nullable-primitive-collection-mutation.The defect
The three recurrence arrays are read conjunctively by
AlternateScheduleSelector.GetScheduleForDate— a miss on any onecontinues — so an empty set matches no date at all.?? []on an omitted array therefore read as "default to no filter" while meaning "default to matching nothing": the API returned HTTP 200 and stored an alternate-schedule or template item that could never apply, with nothing logged. The read side had already been decided the other way in #823 (a NULL column reads as theAll*()sets), so the two halves of "this field is absent" pointed in opposite directions.What ships
Absent and explicitly-empty are two different requests and get two answers:
null— Newtonsoft maps both to null) normalizes toAlternateScheduleSelector.All*(), the same symbols the selector's null guard and bothMapper.ProjectToViewModeloverloads already substitute. NeedsList<T>?on the request records, hence the per-file#nullable enablesibling request records already use.[]is rejected with a 422 naming the consequence, via a new sharedRecurrenceSetBounds(ErsatzTV.Application/Scheduling) called from both replace handlers — theFFmpegProfileBoundsshape prescribed byapi.ffmpeg-profile-numeric-bounds.The rejection lives in the handlers, not the controller, because §3d's "accept an UNCHANGED bad value" rule binds hardest here: both PUT paths are whole-list replaces, so rejecting a pre-existing empty set would make every other item in the list uneditable. That comparison needs the stored row. The exemption is per field, and a stored NULL is not exempt (null means unrestricted).
The validated set is derived from
incoming, the exact list the handler writes, so the highest-Indexcatch-all is excluded by construction — its recurrence is discarded, so rejecting an empty set there would state a reason that is false for that item.Checked before committing to the semantics change
null | Array<T>(nullable, not optional) and it always sends the key;ErsatzTV.Mcp/ToolCatalog.csdefers these replace-list writes. So no existing client took the absent path — the trap was reachable only by a direct API client omitting a field.requiredinv1.json, so the 422 says "send null", not "omit the property", which would instruct a schema violation.ProgramScheduleAlternateandPlayoutTemplateboth hold 0 rows. The exemption is justified by the shape of a whole-list replace, not by that count.Verification
ErsatzTV.Testsfull suite: 2099 passed, 0 failed, 6 skipped.dotnet format whitespace --verify-no-changeson the 6 touched.cs) + BOM check: pass.decisions_validate.py: OK; catalog regenerated.?? All*()reddens exactly the 3 normalization tests; neuteringIsNewlyEmptyreddens exactly the 3 rejection tests; dropping only the stored comparison reddens the 2 exemption tests. Rejection tests also assert the version did not bump.Docs
docs/api-conventions.md§3e (new),docs/decisions/records/api/absent-collection-means-unrestricted.md(new), regenerated catalog, and the #823 record's residual (3) updated to point at the outcome.fixes #880
Review-verdict: MERGEABLE @
3500bf3Cross-family cold review (Codex): first pass BLOCKED with 3 findings, all verified real and fixed by moving the rejection into the handlers; re-review of the fix commit returned MERGEABLE with a boundary matrix over every (submitted x stored) case. 3 mutation proofs executed. Full ErsatzTV.Tests suite 2099 passed / 0 failed.